From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
Cc: German Pacenza <germanp82@hotmail.com>,
58396@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#58396: 29.0.50; Optimization failure for add-to-list
Date: Sat, 30 Sep 2023 09:56:09 -0400 [thread overview]
Message-ID: <jwv5y3r4vmq.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87ttrcaqrm.fsf@sappc2.fritz.box> (Jens Schmidt's message of "Sat, 30 Sep 2023 12:39:57 +0200")
> + (let ((inhibit-message t) ;[1]
> + (warning-minimum-log-level :emergency))
> (advice-add 'macroexpand :around macroexpand-advice)
> - (macroexpand-all sexp))
> + (condition-case nil ;[3]
> + (macroexpand-all sexp)
> + (t sexp)))
This `t` catches more than errors. Better replace it with `error`.
> - (let ((warning-minimum-log-level :emergency))
> + (let ((inhibit-message t) ;[1]
> + (macroexp-inhibit-compiler-macros t) ;[2]
> + (warning-minimum-log-level :emergency))
> (advice-add 'macroexpand-1 :around macroexpand-advice)
> - (macroexpand-all sexp elisp--local-macroenv))
> + (condition-case nil ;[3]
> + (macroexpand-all sexp elisp--local-macroenv)
> + (t sexp)))
What kind of errors are we expecting to catch with this
`condition-case`? The pre-existing advice is supposed to catch macro
expansion errors, and the new let-binding is supposed to catch
compiler-macro errors, so it seems to me there aren't any *expected*
errors left. If so, better remove this `condition-case` (or replace it
with `with-demoted-errors`) since all it has left to do is to hide any
real coding error that may come up and that we'd like to be told about.
Stefan
next prev parent reply other threads:[~2023-09-30 13:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 16:20 bug#58396: 29.0.50; Optimization failure for add-to-list German Pacenza
2022-10-10 8:25 ` Lars Ingebrigtsen
2022-10-10 8:34 ` Lars Ingebrigtsen
2022-10-10 14:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-11 0:28 ` Lars Ingebrigtsen
2022-10-11 1:53 ` Drew Adams
2022-10-11 3:46 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-11 18:27 ` Lars Ingebrigtsen
2022-10-11 19:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-12 10:54 ` Lars Ingebrigtsen
2023-09-26 20:30 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-26 21:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-26 21:48 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-26 22:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-30 10:39 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-30 13:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-09-30 18:44 ` bug#58396: bug#58148: 29.0.50; Wrong number of arguments in keymap-set--anon-cmacro Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-05 18:07 ` bug#60081: " Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-03 19:04 ` bug#58396: 29.0.50; Optimization failure for add-to-list Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-30 14:26 ` Eli Zaretskii
2023-09-30 18:51 ` bug#58148: 29.0.50; Wrong number of arguments in keymap-set--anon-cmacro Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-30 18:54 ` Eli Zaretskii
2023-09-30 22:03 ` bug#58396: 29.0.50; Optimization failure for add-to-list Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv5y3r4vmq.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=58396@debbugs.gnu.org \
--cc=germanp82@hotmail.com \
--cc=jschmidt4gnu@vodafonemail.de \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.