all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require
Date: Tue, 30 Jan 2024 16:41:05 -0500	[thread overview]
Message-ID: <jwv5xzaa4cw.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87jznqve8g.fsf@localhost> (Ihor Radchenko's message of "Tue, 30 Jan 2024 18:59:59 +0000")

Ihor Radchenko [2024-01-30 18:59:59] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> I am wondering if byte-compiler can somehow detect such scenarios and
>>> throw a warning.
>>
>> In theory, if you "fix" the code as I suggested and call `obe-citations`
>> from outside of `org-bibtex-goto-citation`., the byte-compiler could
>> emit a warning.  Is that what you mean?
>
> I mean an opposite: if `declare-function' is called globally, but the
> actual function is only called by a single function in the file, emit
> warning.

I see.  Not sure it would be very useful: the issue is not "it's only
used here" but "it's only *available* here" (because of the
`require`).


        Stefan




  reply	other threads:[~2024-01-30 21:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <170661605561.6823.12101770977814458206@vcs2.savannah.gnu.org>
     [not found] ` <20240130120056.91DA8C0EFEF@vcs2.savannah.gnu.org>
2024-01-30 12:41   ` [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require Stefan Monnier
2024-01-30 15:19     ` Ihor Radchenko
2024-01-30 17:31       ` Stefan Monnier
2024-01-30 18:59         ` Ihor Radchenko
2024-01-30 21:41           ` Stefan Monnier [this message]
2024-01-30 22:11             ` Ihor Radchenko
2024-01-30 22:57               ` Stefan Monnier
2024-01-31 14:51                 ` Emanuel Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv5xzaa4cw.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.