From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71223: 30.0.50; stack overflow after very fast opening and closing of frames Date: Thu, 30 May 2024 18:39:02 -0400 Message-ID: References: <868qzrswpw.fsf@gnu.org> <868qzrqm7h.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31436"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: n142857@gmail.com, cyd@stupidchicken.com, 71223-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 31 00:40:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sCoRU-0007sP-DG for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 May 2024 00:40:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sCoR7-0003yH-9V; Thu, 30 May 2024 18:39:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCoR5-0003xh-Vx for bug-gnu-emacs@gnu.org; Thu, 30 May 2024 18:39:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sCoR5-0002Nm-O1 for bug-gnu-emacs@gnu.org; Thu, 30 May 2024 18:39:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sCoRG-0003BX-9m for bug-gnu-emacs@gnu.org; Thu, 30 May 2024 18:40:02 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 May 2024 22:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 71223 X-GNU-PR-Package: emacs Mail-Followup-To: 71223@debbugs.gnu.org, monnier@iro.umontreal.ca, n142857@gmail.com Original-Received: via spool by 71223-done@debbugs.gnu.org id=D71223.171710876311818 (code D ref 71223); Thu, 30 May 2024 22:40:02 +0000 Original-Received: (at 71223-done) by debbugs.gnu.org; 30 May 2024 22:39:23 +0000 Original-Received: from localhost ([127.0.0.1]:52743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCoQc-00034X-MC for submit@debbugs.gnu.org; Thu, 30 May 2024 18:39:22 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCoQa-00033B-Mz for 71223-done@debbugs.gnu.org; Thu, 30 May 2024 18:39:21 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EC7EB808EE; Thu, 30 May 2024 18:39:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1717108742; bh=FdwmYpg90uGCxDGiQqcc8m3jtKJvZtKPxN9KSCOO4Jk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RuXhCzrAbo4c4ICv7BfhGvzTqbdieuWFun6dAj1py+Xl+Fgqv4xW/MmdzDxzmxGU8 /HryVCTZNwU126NPMnFmkPzYC40F2Z9D3Vbs5eovYq1jYrp2AQw4xZQncI1MSPQvE+ x5fi9ZqbLsJMNHNWSmlF/F5o4T5wBt5nHelbrwTiCTJAdGPlSR3N6Ivv3SmsLTWRDG E39/R5VKqWIt4cPbv1hzGwbdfgaijhsk3g/X5NwkCcRW+Z/zYTDzmc8vykOgpu8EWl rEtWHFeQBwMbqJN7GKk+IZfyl6gj6VyFg9lKZFT60IkpPDUdXPTHIjV6ovr+KvBfY7 woHGC6hGUrnbw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E67D7806EF; Thu, 30 May 2024 18:39:02 -0400 (EDT) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D05A01205EF; Thu, 30 May 2024 18:39:02 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Thu, 30 May 2024 14:24:11 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286246 Archived-At: OK, I think I understand the code well enough now that I'm confident my current patch is an overall improvement, and pushed it to `master`. I think the problem is not completely specific to server.el's process filter, so it might be be worthwhile to add some more generic support for this kind of situation (e.g. ways to force some process filters to be run sequentially rather than in a nested fashion, as well as ways for process filters to know if there's already more work pending so as to better handle bursts of concurrent requests). I also still have some FIXMEs in the code (one for `server--message-sit-for` which I think deserves to be better implemented and moved to core, and another for the question of the 5s vs 1s). But w.r.t this bug report, I think we're done, so I'm closing it. Stefan