From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71644: 30.0.50; Severe slowdown in larger files with markers beginning in emacs 29+ Date: Fri, 21 Jun 2024 17:06:31 -0400 Message-ID: References: <86ed8tozub.fsf@gnu.org> <86jzijmo5a.fsf@gnu.org> <86y16ylrj9.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25795"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Mitchell , 71644@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 21 23:07:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKlTj-0006U4-07 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jun 2024 23:07:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKlTN-0004zU-9e; Fri, 21 Jun 2024 17:07:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKlTL-0004zI-I4 for bug-gnu-emacs@gnu.org; Fri, 21 Jun 2024 17:07:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKlTL-0003O6-AD for bug-gnu-emacs@gnu.org; Fri, 21 Jun 2024 17:07:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sKlTK-0005Rc-Gm for bug-gnu-emacs@gnu.org; Fri, 21 Jun 2024 17:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jun 2024 21:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71644 X-GNU-PR-Package: emacs Original-Received: via spool by 71644-submit@debbugs.gnu.org id=B71644.171900400120901 (code B ref 71644); Fri, 21 Jun 2024 21:07:02 +0000 Original-Received: (at 71644) by debbugs.gnu.org; 21 Jun 2024 21:06:41 +0000 Original-Received: from localhost ([127.0.0.1]:43914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKlSz-0005R3-1W for submit@debbugs.gnu.org; Fri, 21 Jun 2024 17:06:41 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:26745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKlSw-0005Qp-TO for 71644@debbugs.gnu.org; Fri, 21 Jun 2024 17:06:39 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D836980C8E; Fri, 21 Jun 2024 17:06:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1719003992; bh=81OivFs9r+nGAZQWPRJLhFVkh+8Iikb80wJuUJcMCFo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=CYxWo/mmCerOGaEVPLuPR1HQbCCB1VfOX/2Iu9kZKiYFfkpQAxIEy9cZIkb4trPvd EZbRrQot0RY6FeTLV4q0HAXmdkjRmERepMFVHq2axC7dK8dMZhoozMvLl/ZGWxJhyZ dl5YtT4RWbK8XJLBDGgwwasVGXQ4MDsPjfGEBG/GSWBHMMrfR5EWHxX7Fb209ocUpJ C79tQRJH+w79YdBoBUch1RfKUkeye1aOL+LcxNcGh4x4MbfJKpkOUullT66Ca42FBT NIFEoY/+p3ZFwwz2Dh6aP0eESdDCyM4D4BRDn3KwJYuirr7DJZpoCeRXl7vcTFmNY6 B1hq9noPuhE2A== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A7940807F5; Fri, 21 Jun 2024 17:06:32 -0400 (EDT) Original-Received: from asado (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 61AE51202B5; Fri, 21 Jun 2024 17:06:32 -0400 (EDT) In-Reply-To: <86y16ylrj9.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 21 Jun 2024 09:48:58 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287640 Archived-At: > commit 8783700b23e70874c4996908bf02c010ae6f3fe1 > Author: Stefan Monnier > AuthorDate: Tue Aug 2 10:38:53 2022 -0400 > Commit: Stefan Monnier > CommitDate: Tue Aug 2 13:06:51 2022 -0400 > > * src/xdisp.c (redisplay_window): Use BEG rather than hard coding 1 > > It changed the comparison operator in two places in marker.c. > > Curiously, the log message doesn't even mention the change in > marker.c, which could be a sign that this change was not intended to > be installed. Stefan, did you intend to install it, and if so, do you > have any comments about this bug report? Hmm... can't remember why/how it ended up in the above commit. Looks like an oversight. But the change should be harmless: the `eassert` should make sure that the comparison gives the same answer either way (and AFAICT if/when the new comparison gives a different answer from the old code, the old code will loop until it segfaults). > I'm a bit confused by the fact that I don't see the slowdown on my > machine, but maybe there are other factors at work here that hide > the regression. The byte<->char conversion code is affected by many unrelated moving parts, so it can be difficult to come up with a reproducible recipe. Stefan