* pcl-cvs's prompts
@ 2003-09-19 8:19 Masatake YAMATO
2003-09-19 16:01 ` Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: Masatake YAMATO @ 2003-09-19 8:19 UTC (permalink / raw)
pcl-cvs's prompts shown when I press `r(cvs-mode-remove)' and
`U(cvs-mode-unde)' are the same:
Delete file: "foo.el" ? (yes or no)
They should be different to avoid the users are confused.
For undo:
Restore file: "foo.el" ? (yes or no)
For remoev:
Delete file: "foo.el" ? (yes or no)
Masatake YAMATO
2003-09-19 Masatake YAMATO <jet@gyve.org>
* pcvs.el (cvs-do-removal): Change the prompt depending on
`filter' value.
Index: lisp/pcvs.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/pcvs.el,v
retrieving revision 1.62
diff -u -r1.62 pcvs.el
--- lisp/pcvs.el 1 Sep 2003 15:45:14 -0000 1.62
+++ lisp/pcvs.el 19 Sep 2003 08:17:04 -0000
@@ -2044,11 +2044,15 @@
(if (not (or silent
(unwind-protect
(yes-or-no-p
- (let ((nfiles (length files)))
+ (let ((nfiles (length files))
+ (verb (if (eq filter 'undo) "Restore" "Delete")))
(if (= 1 nfiles)
- (format "Delete file: \"%s\" ? "
+ (format "%s file: \"%s\" ? "
+ verb
(cvs-fileinfo->file (car files)))
- (format "Delete %d files? " nfiles))))
+ (format "%s %d files? "
+ verb
+ nfiles))))
(cvs-bury-buffer tmpbuf cvs-buffer))))
(progn (message "Aborting") nil)
(dolist (fi files)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: pcl-cvs's prompts
2003-09-19 8:19 pcl-cvs's prompts Masatake YAMATO
@ 2003-09-19 16:01 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2003-09-19 16:01 UTC (permalink / raw)
Cc: emacs-devel
> pcl-cvs's prompts shown when I press `r(cvs-mode-remove)' and
> `U(cvs-mode-unde)' are the same:
> Delete file: "foo.el" ? (yes or no)
> They should be different to avoid the users are confused.
Great. I'd prefer "Undo" rather than "Restore" (not because I prefer that
verb or find it more appropriate but because it's the verb that used
everywhere else in PCL-CVS for that operation), but please install
your patch.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-09-19 16:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-19 8:19 pcl-cvs's prompts Masatake YAMATO
2003-09-19 16:01 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.