pcl-cvs's prompts

pcl-cvs's prompts

[Masatake YAMATO]

pcl-cvs's prompts shown when I press `r(cvs-mode-remove)' and
`U(cvs-mode-unde)' are the same:

		   Delete file: "foo.el" ? (yes or no) 

They should be different to avoid the users are confused.

For undo:
		   Restore file: "foo.el" ? (yes or no) 

For remoev:
		   Delete file: "foo.el" ? (yes or no) 

Masatake YAMATO

2003-09-19  Masatake YAMATO  <jet@gyve.org>

	* pcvs.el (cvs-do-removal): Change the prompt depending on
	`filter' value.

Index: lisp/pcvs.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/pcvs.el,v
retrieving revision 1.62
diff -u -r1.62 pcvs.el
--- lisp/pcvs.el	1 Sep 2003 15:45:14 -0000	1.62
+++ lisp/pcvs.el	19 Sep 2003 08:17:04 -0000
@@ -2044,11 +2044,15 @@
     (if (not (or silent
 		 (unwind-protect
 		     (yes-or-no-p 
-		      (let ((nfiles (length files)))
+		      (let ((nfiles (length files))
+			    (verb (if (eq filter 'undo) "Restore" "Delete")))
 			(if (= 1 nfiles)
-			    (format "Delete file: \"%s\" ? " 
+			    (format "%s file: \"%s\" ? " 
+				    verb
 				    (cvs-fileinfo->file (car files)))
-			  (format "Delete %d files? " nfiles))))
+			  (format "%s %d files? " 
+				  verb
+				  nfiles))))
 		   (cvs-bury-buffer tmpbuf cvs-buffer))))
 	(progn (message "Aborting") nil)
       (dolist (fi files)

Re: pcl-cvs's prompts

[Stefan Monnier]

> pcl-cvs's prompts shown when I press `r(cvs-mode-remove)' and
> `U(cvs-mode-unde)' are the same:

> 		   Delete file: "foo.el" ? (yes or no) 

> They should be different to avoid the users are confused.

Great.  I'd prefer "Undo" rather than "Restore" (not because I prefer that
verb or find it more appropriate but because it's the verb that used
everywhere else in PCL-CVS for that operation), but please install
your patch.


        Stefan