From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
Newsgroups: gmane.emacs.devel
Subject: Re: bug in diff-mode.el?
Date: 05 Nov 2003 08:55:56 -0500
Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Message-ID: <jwv4qxiex9s.fsf-monnier+emacs/devel@vor.iro.umontreal.ca>
References: <bo9bkp$pgs$1@sea.gmane.org>
NNTP-Posting-Host: deer.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: sea.gmane.org 1068049583 2275 80.91.224.253 (5 Nov 2003 16:26:23 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Wed, 5 Nov 2003 16:26:23 +0000 (UTC)
Cc: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Nov 05 17:26:20 2003
Return-path: <emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AHQU8-0001xl-00
	for <emacs-devel@deer.gmane.org>; Wed, 05 Nov 2003 17:26:20 +0100
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AHQU8-0000So-00
	for <emacs-devel@quimby.gnus.org>; Wed, 05 Nov 2003 17:26:20 +0100
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.24)
	id 1AHQ8i-0006g5-RX
	for emacs-devel@quimby.gnus.org; Wed, 05 Nov 2003 11:04:12 -0500
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHQ4S-0005u9-6t
	for emacs-devel@gnu.org; Wed, 05 Nov 2003 10:59:48 -0500
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHQ3r-0005j9-1y
	for emacs-devel@gnu.org; Wed, 05 Nov 2003 10:59:43 -0500
Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AHQ3q-0005iN-FC
	for emacs-devel@gnu.org; Wed, 05 Nov 2003 10:59:10 -0500
Original-Received: from vor.iro.umontreal.ca (vor.iro.umontreal.ca [132.204.24.42])
	by mercure.iro.umontreal.ca (8.12.9/8.12.9) with ESMTP id
	hA5Dtupx022705; Wed, 5 Nov 2003 08:55:56 -0500
Original-Received: by vor.iro.umontreal.ca (Postfix, from userid 20848)
	id 7AAAB3C63E; Wed,  5 Nov 2003 08:55:56 -0500 (EST)
Original-To: Martin Stone Davis <m0davis@pacbell.net>
In-Reply-To: <bo9bkp$pgs$1@sea.gmane.org>
Original-Lines: 18
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
X-DIRO-MailScanner: Found to be clean
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Emacs development discussions.  <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Xref: main.gmane.org gmane.emacs.devel:17697
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:17697

> The following code looks wrong to me:

Looks wrong to me as well.

> Shouldn't it be: (max end (cdr diff-unhandled-changes)) ?

Yup.  As a matter of fact that's how it is in Emacs-CVS already.

> This is version 21.3.1.

Haha!  Sucker!


        Stefan


PS: Just kidding about that last part.  Thanks for your report and sorry
    I had already fixed it before your reported it.