all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug in diff-mode.el?
@ 2003-11-04 23:11 Martin Stone Davis
  2003-11-05 13:55 ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Stone Davis @ 2003-11-04 23:11 UTC (permalink / raw)


The following code looks wrong to me:

(defun diff-after-change-function (beg end len)
   "Remember to fixup the hunk header.
See `after-change-functions' for the meaning of BEG, END and LEN."
...
   (when (and (not undo-in-progress) (not inhibit-read-only))
     (if diff-unhandled-changes
	(setq diff-unhandled-changes
	      (cons (min beg (car diff-unhandled-changes))
		    (max beg (cdr diff-unhandled-changes))))
                 ---------^^^
       (setq diff-unhandled-changes (cons beg end)))))


Shouldn't it be: (max end (cdr diff-unhandled-changes)) ?

This is version 21.3.1.

-Martin

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: bug in diff-mode.el?
  2003-11-04 23:11 bug in diff-mode.el? Martin Stone Davis
@ 2003-11-05 13:55 ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2003-11-05 13:55 UTC (permalink / raw)
  Cc: emacs-devel

> The following code looks wrong to me:

Looks wrong to me as well.

> Shouldn't it be: (max end (cdr diff-unhandled-changes)) ?

Yup.  As a matter of fact that's how it is in Emacs-CVS already.

> This is version 21.3.1.

Haha!  Sucker!


        Stefan


PS: Just kidding about that last part.  Thanks for your report and sorry
    I had already fixed it before your reported it.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-11-05 13:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-11-04 23:11 bug in diff-mode.el? Martin Stone Davis
2003-11-05 13:55 ` Stefan Monnier

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.