From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: grep-use-null-device Date: Thu, 01 Sep 2005 14:18:30 -0400 Message-ID: References: <87ll2kiczv.fsf@jurta.org> <878xyiyh2n.fsf-monnier+emacs@gnu.org> <87mzmy1wmh.fsf@jurta.org> <85slwovk53.fsf@lola.goethe.zz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1125598980 14043 80.91.229.2 (1 Sep 2005 18:23:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 1 Sep 2005 18:23:00 +0000 (UTC) Cc: Juri Linkov , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 01 20:22:59 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EAtgz-0007GG-8n for ged-emacs-devel@m.gmane.org; Thu, 01 Sep 2005 20:21:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EAtlE-0005HH-JJ for ged-emacs-devel@m.gmane.org; Thu, 01 Sep 2005 14:26:04 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EAtkt-0005Fv-SN for emacs-devel@gnu.org; Thu, 01 Sep 2005 14:25:44 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EAtkq-0005EC-2z for emacs-devel@gnu.org; Thu, 01 Sep 2005 14:25:41 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EAtkp-0005E9-VD for emacs-devel@gnu.org; Thu, 01 Sep 2005 14:25:40 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EAtgt-0003Zd-PE; Thu, 01 Sep 2005 14:21:35 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 654D52CF54D; Thu, 1 Sep 2005 14:18:35 -0400 (EDT) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id E547E4AC00A; Thu, 1 Sep 2005 14:18:30 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id CE591504E; Thu, 1 Sep 2005 14:18:30 -0400 (EDT) Original-To: David Kastrup In-Reply-To: <85slwovk53.fsf@lola.goethe.zz> (David Kastrup's message of "Thu, 01 Sep 2005 18:16:08 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-4.844, requis 5, autolearn=not spam, AWL 0.06, BAYES_00 -4.90) X-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:42562 Archived-At: >> + (when compilation-disable-input >> + (condition-case nil >> + (process-send-eof proc) >> + ;; The process may have exited already. >> + (error nil))) >> (setq compilation-in-progress >> (cons proc compilation-in-progress))) >> ;; No asynchronous processes available. > I think it is the wrong fix to just ignore an error which should not > occur in the first place. Rather process-send-eof should be fixed not > to throw an error as long as the process is not considered dead from > Emacs' point of view. That there is nobody to actually look at the > eof can't be considered a problem in asynchronous operations: the > consuming process can close down without waiting for an explicit eof. I agree it'd be the better thing to do. But I have no patch to do that, so unless someone else can provide a patch for it, my suggestion is a good temporary workaround. Stefan