From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 22.1.50; newsticker and buffer-invisibility-spec: Date: Mon, 20 Aug 2007 10:27:05 -0400 Message-ID: References: <20070820132850.326D212A4071@localhost> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1187620042 809 80.91.229.12 (20 Aug 2007 14:27:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 20 Aug 2007 14:27:22 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: raman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 20 16:27:20 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IN8Dv-00068D-Oi for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2007 16:27:20 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IN8Dv-0002gG-SJ for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2007 10:27:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IN8Dq-0002dr-4U for emacs-devel@gnu.org; Mon, 20 Aug 2007 10:27:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IN8Do-0002cK-Ig for emacs-devel@gnu.org; Mon, 20 Aug 2007 10:27:13 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IN8Do-0002c8-B4 for emacs-devel@gnu.org; Mon, 20 Aug 2007 10:27:12 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IN8Dn-0005eL-My for emacs-devel@gnu.org; Mon, 20 Aug 2007 10:27:11 -0400 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IN8Hh-0007wS-Ej for emacs-pretest-bug@gnu.org; Mon, 20 Aug 2007 10:31:13 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1IN8Dj-0005dz-JS for emacs-pretest-bug@gnu.org; Mon, 20 Aug 2007 10:27:11 -0400 Original-Received: from tomts40.bellnexxia.net ([209.226.175.97] helo=tomts40-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IN8Dj-0005dt-Aw for emacs-pretest-bug@gnu.org; Mon, 20 Aug 2007 10:27:07 -0400 Original-Received: from pastel.home ([70.53.193.20]) by tomts40-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20070820142705.NGRZ29719.tomts40-srv.bellnexxia.net@pastel.home> for ; Mon, 20 Aug 2007 10:27:05 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 7B3167FD2; Mon, 20 Aug 2007 10:27:05 -0400 (EDT) In-Reply-To: <20070820132850.326D212A4071@localhost> (raman@users.sf.net's message of "Mon\, 20 Aug 2007 06\:28\:50 -0700 \(PDT\)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-Detected-Kernel: Solaris 8 (1) X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:76831 gmane.emacs.pretest.bugs:19566 Archived-At: > I've not used newsticker in a while, and I noticed today that there seems > to be a problem with the way buffer-invisibility-spec is getting handled > in newsticker buffers. > Could someone who can see the display look at it and confirm that > there is a problem, or that it is indeed doing the right thing so > I can chase this down further? I don't know how to run the newsticker code to try it out, but the code looks odd indeed: it presumes that the invisibility property can be a list of values and that if one of those values is a member of buffer-invisibility-spec then the text is invisible. But in reality, the invisible property is not treated as a list, its value (which could presumably be a list, but that would be asking for trouble) is directly looked up in buffer-invisibility-spec. I.e. newsticker--lists-intersect-p (which is always called with (get-text-property FOO 'invisible) as first arg and buffer-invisibility-spec as second, so it should really be replaced by a new function newsticker--invisible-p) should be newsticker--list-member-p or somesuch. But fixing this function is not enough because the rest of the code makes use of the nonexistent feature. I've looked at the XEmacs-21.4.20 docstring for buffer-invisibility-spec and it doesn't seem to document such an extension either, so I have no idea in which circumstance this code may work. The problematic code was part of the 1.1 revision (checked in on 12 Sep 2005), so there's no change log to explain the problem. Stefan