From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.comp.gnu.utils.bugs Subject: Re: diff-mode misinterprets empty lines. Date: Thu, 29 Nov 2007 11:09:41 -0500 Message-ID: References: <85ir3l767y.fsf@lola.goethe.zz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1196352632 489 80.91.229.12 (29 Nov 2007 16:10:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 29 Nov 2007 16:10:32 +0000 (UTC) Cc: , rms@gnu.org, emacs-devel@gnu.org To: bug-gnu-utils@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 29 17:10:40 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ixlxp-0007Iy-JU for ged-emacs-devel@m.gmane.org; Thu, 29 Nov 2007 17:10:10 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IxlxZ-00055z-Kj for ged-emacs-devel@m.gmane.org; Thu, 29 Nov 2007 11:09:53 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IxlxX-00055m-24 for emacs-devel@gnu.org; Thu, 29 Nov 2007 11:09:51 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IxlxW-00055S-M1 for emacs-devel@gnu.org; Thu, 29 Nov 2007 11:09:50 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IxlxU-00054z-Ne; Thu, 29 Nov 2007 11:09:48 -0500 Original-Received: from tomts25.bellnexxia.net ([209.226.175.188] helo=tomts25-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IxlxP-0000z0-0u; Thu, 29 Nov 2007 11:09:43 -0500 Original-Received: from toip4.srvr.bell.ca ([209.226.175.87]) by tomts25-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20071129160942.LUVS19497.tomts25-srv.bellnexxia.net@toip4.srvr.bell.ca>; Thu, 29 Nov 2007 11:09:42 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aq4HAGNzTkdGN4zh/2dsb2JhbACBWw Original-Received: from bas1-montreal42-1178045665.dsl.bell.ca (HELO pastel.home) ([70.55.140.225]) by toip4.srvr.bell.ca with ESMTP; 29 Nov 2007 11:12:13 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 9FD117F61; Thu, 29 Nov 2007 11:09:41 -0500 (EST) In-Reply-To: <85ir3l767y.fsf@lola.goethe.zz> (David Kastrup's message of "Thu, 29 Nov 2007 10:26:25 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84310 gmane.comp.gnu.utils.bugs:15268 Archived-At: >> GNU diff since version 2.8.7 outputs empty lines in the unified diff >> format for empty context lines that don't change (instead of single >> space followed by newline). See, e.g., the thread starting here: >> >> > I have to agree with those thinking it is a terrible idea to prune > trailing spaces that are part of the _diff_ format. Agreed as well, this is a terrible idea. Making tools somewhat robust in the face of lost trailing whitespace is good (diff-mode does that), but actively removing them is bad. What's the benefit, really? The original post said "This doesn't really matter..." and I agree with this part. So breaking every/most program that parses diffs just because "when the only trailing blanks in a diff are those in context headers, it's a little annoying" seems gratuitous. Could you please revert this change? Stefan "Author of Emacs's diff-mode"