From: Stefan Monnier <monnier@iro.umontreal.ca>
To: bug-gnu-utils@gnu.org
Cc: , rms@gnu.org, emacs-devel@gnu.org
Subject: Re: diff-mode misinterprets empty lines.
Date: Thu, 29 Nov 2007 11:09:41 -0500 [thread overview]
Message-ID: <jwv4pf5598v.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <85ir3l767y.fsf@lola.goethe.zz> (David Kastrup's message of "Thu, 29 Nov 2007 10:26:25 +0100")
>> GNU diff since version 2.8.7 outputs empty lines in the unified diff
>> format for empty context lines that don't change (instead of single
>> space followed by newline). See, e.g., the thread starting here:
>>
>> <http://lists.gnu.org/archive/html/bug-gnu-utils/2006-09/msg00005.html>
> I have to agree with those thinking it is a terrible idea to prune
> trailing spaces that are part of the _diff_ format.
Agreed as well, this is a terrible idea. Making tools somewhat robust
in the face of lost trailing whitespace is good (diff-mode does that),
but actively removing them is bad.
What's the benefit, really?
The original post said "This doesn't really matter..." and I agree with
this part. So breaking every/most program that parses diffs just
because "when the only trailing blanks in a diff are those in context headers,
it's a little annoying" seems gratuitous.
Could you please revert this change?
Stefan "Author of Emacs's diff-mode"
next prev parent reply other threads:[~2007-11-29 16:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 1:03 diff-mode misinterprets empty lines Richard Stallman
2007-11-29 9:26 ` David Kastrup
2007-11-29 16:09 ` Stefan Monnier [this message]
2007-12-05 7:35 ` Paul Eggert
2007-12-05 10:17 ` Jim Meyering
2007-12-05 10:58 ` David Kastrup
2007-12-05 11:27 ` Jim Meyering
2007-12-05 12:33 ` Andreas Schwab
2007-12-05 12:39 ` Jim Meyering
2007-12-05 14:59 ` David Kastrup
2007-12-05 17:45 ` Paul Eggert
2007-12-05 18:12 ` David Kastrup
2007-12-06 0:54 ` Paul Eggert
2007-12-06 10:11 ` Andreas Schwab
2007-12-05 21:04 ` Juanma Barranquero
2007-12-06 15:39 ` Stefan Monnier
2008-01-06 0:15 ` Glenn Morris
2008-01-06 18:09 ` Richard Stallman
2008-01-14 21:08 ` Stefan Monnier
2008-01-14 21:38 ` Glenn Morris
2008-01-14 22:46 ` Glenn Morris
2008-01-14 23:35 ` Diffs between %s and %s end here (was: diff-mode misinterprets empty lines.) Reiner Steib
2008-01-15 3:29 ` Diffs between %s and %s end here Miles Bader
2008-01-16 8:13 ` Glenn Morris
2008-01-15 0:09 ` diff-mode misinterprets empty lines Dan Nicolaescu
2008-01-29 18:37 ` Chong Yidong
2008-02-19 16:32 ` Stefan Monnier
2008-02-19 20:44 ` Stefan Monnier
2007-12-06 2:11 ` Richard Stallman
2007-12-05 17:48 ` Paul Eggert
2007-12-05 17:50 ` Jim Meyering
2007-11-29 22:31 ` Richard Stallman
2007-11-29 23:12 ` David Kastrup
2007-11-30 2:03 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2007-11-27 18:04 Sergei Organov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4pf5598v.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=bug-gnu-utils@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.