From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacsclient -n problems Date: Sun, 23 Dec 2007 17:46:23 -0500 Message-ID: References: <20071215110924.GA52148@orion.lan> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1198450002 22103 80.91.229.12 (23 Dec 2007 22:46:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 23 Dec 2007 22:46:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Emanuele Giaquinta Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 23 23:46:54 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J6Zas-0004bO-IV for ged-emacs-devel@m.gmane.org; Sun, 23 Dec 2007 23:46:50 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J6ZaY-0008Ad-BD for ged-emacs-devel@m.gmane.org; Sun, 23 Dec 2007 17:46:30 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J6ZaU-0008AP-G2 for emacs-devel@gnu.org; Sun, 23 Dec 2007 17:46:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J6ZaT-0008AD-3l for emacs-devel@gnu.org; Sun, 23 Dec 2007 17:46:25 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J6ZaS-0008AA-Us for emacs-devel@gnu.org; Sun, 23 Dec 2007 17:46:24 -0500 Original-Received: from zue-tix-bbcs-dynip-188-041.vtx.ch ([83.228.188.41] helo=ceviche.home) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J6ZaS-0005US-Ht for emacs-devel@gnu.org; Sun, 23 Dec 2007 17:46:24 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id B3555B40F3; Sun, 23 Dec 2007 17:46:23 -0500 (EST) In-Reply-To: <20071215110924.GA52148@orion.lan> (Emanuele Giaquinta's message of "Sat, 15 Dec 2007 12:09:24 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85422 Archived-At: > emacs -Q --eval '(server-start)' > emacsclient -nc > evaluate '(save-buffers-kill-terminal)' in the client > Debugger entered--Lisp error: (wrong-type-argument processp nowait) I've just installed the patch below which should fix this problem. Stefan Index: lisp/server.el =================================================================== RCS file: /sources/emacs/emacs/lisp/server.el,v retrieving revision 1.154 diff -u -r1.154 server.el --- lisp/server.el 10 Dec 2007 03:51:25 -0000 1.154 +++ lisp/server.el 23 Dec 2007 22:43:44 -0000 @@ -1260,12 +1260,16 @@ ;;;###autoload (defun server-save-buffers-kill-terminal (proc &optional arg) + ;; Called from save-buffers-kill-terminal in files.el. "Offer to save each buffer, then kill PROC. With prefix arg, silently save all file-visiting buffers, then kill. If emacsclient was started with a list of filenames to edit, then only these files will be asked to be saved." + ;; save-buffers-kill-terminal occasionally calls us with proc set + ;; to `nowait' (comes from the value of the `client' frame parameter). + (when (processp proc) (let ((buffers (process-get proc 'buffers))) ;; If client is bufferless, emulate a normal Emacs session ;; exit and offer to save all buffers. Otherwise, offer to @@ -1274,7 +1278,7 @@ (if buffers (lambda () (memq (current-buffer) buffers)) t)) - (server-delete-client proc))) + (server-delete-client proc)))) (define-key ctl-x-map "#" 'server-edit)