all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Emanuele Giaquinta <emanuele.giaquinta@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: emacsclient -n problems
Date: Sun, 23 Dec 2007 17:46:23 -0500	[thread overview]
Message-ID: <jwv4pe9ghdz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20071215110924.GA52148@orion.lan> (Emanuele Giaquinta's message of "Sat, 15 Dec 2007 12:09:24 +0100")

> emacs -Q --eval '(server-start)'
> emacsclient -nc
> evaluate '(save-buffers-kill-terminal)' in the client

> Debugger entered--Lisp error: (wrong-type-argument processp nowait)

I've just installed the patch below which should fix this problem.


        Stefan


Index: lisp/server.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/server.el,v
retrieving revision 1.154
diff -u -r1.154 server.el
--- lisp/server.el	10 Dec 2007 03:51:25 -0000	1.154
+++ lisp/server.el	23 Dec 2007 22:43:44 -0000
@@ -1260,12 +1260,16 @@
 
 ;;;###autoload
 (defun server-save-buffers-kill-terminal (proc &optional arg)
+  ;; Called from save-buffers-kill-terminal in files.el.
   "Offer to save each buffer, then kill PROC.
 
 With prefix arg, silently save all file-visiting buffers, then kill.
 
 If emacsclient was started with a list of filenames to edit, then
 only these files will be asked to be saved."
+  ;; save-buffers-kill-terminal occasionally calls us with proc set
+  ;; to `nowait' (comes from the value of the `client' frame parameter).
+  (when (processp proc)
   (let ((buffers (process-get proc 'buffers)))
     ;; If client is bufferless, emulate a normal Emacs session
     ;; exit and offer to save all buffers.  Otherwise, offer to
@@ -1274,7 +1278,7 @@
 		       (if buffers
 			   (lambda () (memq (current-buffer) buffers))
 			 t))
-    (server-delete-client proc)))
+      (server-delete-client proc))))
 
 (define-key ctl-x-map "#" 'server-edit)

      parent reply	other threads:[~2007-12-23 22:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-15 11:09 emacsclient -n problems Emanuele Giaquinta
2007-12-21  0:06 ` Stefan Monnier
2007-12-23 22:46 ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv4pe9ghdz.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=emanuele.giaquinta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.