From: Stefan Monnier <monnier@iro.umontreal.ca>
To: martin rudalics <rudalics@gmx.at>
Cc: Katsumi Yamaoka <yamaoka@jpl.org>, emacs-devel@gnu.org
Subject: Re: undo bug?
Date: Wed, 02 Apr 2008 09:59:14 -0400 [thread overview]
Message-ID: <jwv4pak8inz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <47F2A0C7.7030402@gmx.at> (martin rudalics's message of "Tue, 01 Apr 2008 22:53:27 +0200")
>>> Couldn't we do away with undo-boundaries and always undo until the next
>>> recorded position of `point'?
>> In theory we could, but that may break various packages: of all the
>> supported undo records, the "undo-boundary" is probably the only one
>> that is used by external packages ;-(
> What I had in mind was that `undo-boundary' would simply `record-point'
> instead of inserting nil.
Yes, that's indeed what I had understood from your earlier message and
what I was responding to. You're remove the undo boundaries (i.e. the
nil entries) and replace them by point-record entries. That would work
fine, except that there are packages out there that look for the
nil entries.
>> Instead the current code tries to only insert a point-record when
>> it's actually necessary.
> Sometimes. For example I use the patch below to handle the (pretty
> annoying) problem that when I redo an earlier insertion `point' ends up
> _before_ the inserted text (my `undo' binds `undo-is-redo' to `equiv'
> when calling `undo-more').
Have you tried to analyze the source of the problem? Maybe there are
cases where we incorrectly decide not to put a point-record even tho it
is needed.
Stefan
next prev parent reply other threads:[~2008-04-02 13:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-01 11:06 undo bug? Katsumi Yamaoka
2008-04-01 11:43 ` martin rudalics
2008-04-01 11:55 ` Katsumi Yamaoka
2008-04-01 15:07 ` Stefan Monnier
2008-04-01 18:52 ` martin rudalics
2008-04-01 19:25 ` Stefan Monnier
2008-04-01 20:53 ` martin rudalics
2008-04-02 13:59 ` Stefan Monnier [this message]
2008-04-02 17:01 ` martin rudalics
2008-04-03 13:55 ` Stefan Monnier
2008-04-03 14:43 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4pak8inz.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=rudalics@gmx.at \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.