From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Karl Chen <quarl@cs.berkeley.edu>
Cc: emacs-devel@gnu.org
Subject: Re: cal-x.el/diary-lib.el diary-mode-hook
Date: Thu, 15 May 2008 10:52:15 -0400 [thread overview]
Message-ID: <jwv4p8zwrpx.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <quack.20080515T0252.lth8wyb3ndx@roar.cs.berkeley.edu> (Karl Chen's message of "Thu, 15 May 2008 02:52:26 -0700")
> Hi, this is regarding calendar. I experience the symptoms in
> Emacs 22.2, and by inspecting CVS HEAD I suspect it is still
> affected despite the code having been significantly updated.
> emacs -q
> (setq diary-display-hook 'fancy-diary-display)
> (setq calendar-setup 'one-frame)
> (calendar)
> A couple places in calendar/*.el seem to assume that
> diary-mode-hook is a list of functions, e.g. when it uses ``(memq
> 'diary-fancy-display diary-display-hook)''.
> In my setup I had ``(setq diary-display-hook
> 'fancy-schedule-display-desk-calendar)'' [instead of add-hook or
> ``setq .. '(..)''] and this would trigger a type error.
> I realize the documentation for diary-display-hook says "list of
> functions", but a couple places in the code let-bind
> diary-display-hook to non-lists, and the documentation in 22.2 has
> sample code with non-lists.
Hooks accept either a function or a list of functions, where the former
is only accepted for historical reasons. So all the code that sets
hooks to a single function should be reported as (minor) bugs, and all
the documentation that does that should be reported as (non-minor) bugs.
A quick grep in the EMACS_22_BASE branch disn't show me the sample code
you refer to, so could you please tell us where you found it?
This said, using `memq' on a hook is indeed an error.
Stefan
PS: You should "never" modify a hook with setq, always use `add-hook'.
next prev parent reply other threads:[~2008-05-15 14:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 9:52 cal-x.el/diary-lib.el diary-mode-hook Karl Chen
2008-05-15 14:52 ` Stefan Monnier [this message]
2008-05-15 19:28 ` Karl Chen
2008-05-17 20:24 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4p8zwrpx.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=quarl@cs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.