From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [patch] vc-find-root with invert Date: Mon, 21 Jul 2008 22:56:16 -0400 Message-ID: References: <486E5CE0.5090004@justinbogner.com> <486E668E.2050600@justinbogner.com> <20080705072126.GA936@tomas> <4884B8FC.9040301@justinbogner.com> <488500C2.8060001@justinbogner.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1216695780 27475 80.91.229.12 (22 Jul 2008 03:03:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 22 Jul 2008 03:03:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Justin Bogner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 22 05:03:48 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KL8AD-0001Es-H8 for ged-emacs-devel@m.gmane.org; Tue, 22 Jul 2008 05:03:45 +0200 Original-Received: from localhost ([127.0.0.1]:57325 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KL89K-0000pY-37 for ged-emacs-devel@m.gmane.org; Mon, 21 Jul 2008 23:02:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KL89F-0000n6-6T for emacs-devel@gnu.org; Mon, 21 Jul 2008 23:02:45 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KL89E-0000lw-Fm for emacs-devel@gnu.org; Mon, 21 Jul 2008 23:02:44 -0400 Original-Received: from [199.232.76.173] (port=38352 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KL89E-0000ll-C5 for emacs-devel@gnu.org; Mon, 21 Jul 2008 23:02:44 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:62604 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KL89D-0004Vm-Vd for emacs-devel@gnu.org; Mon, 21 Jul 2008 23:02:44 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aq4EAP/qhEhFxIYw/2dsb2JhbACBWq1PgXo X-IronPort-AV: E=Sophos;i="4.31,228,1215403200"; d="scan'208";a="24618685" Original-Received: from 69-196-134-48.dsl.teksavvy.com (HELO ceviche.home) ([69.196.134.48]) by ironport2-out.teksavvy.com with ESMTP; 21 Jul 2008 23:02:42 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 84672B42DE; Mon, 21 Jul 2008 22:56:16 -0400 (EDT) In-Reply-To: <488500C2.8060001@justinbogner.com> (Justin Bogner's message of "Mon, 21 Jul 2008 15:33:54 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101154 Archived-At: > However, for the other case, we need traverse upwards until we don't > find the directory, returning the last one that does. As it stands, if > we don't find the directory we look, we return wherever we started > searching, which is incorrect. It's not incorrect at all. It's how CVS and Svn work. They don't have a "root directory". you may have /foo/baqr/CVS and /foo/CVS, but it doesn't mean /foo is the root: the two may be simply unrelated. I.e. it's tryuing to invent something that's simply not there. No other CVS or Svn front-end does that as far I know. The user specifies the root he wants to use when it starts vc-dir: Emacs doesn't need to guess it. I.e. VC's "root dir" is not something for the UI but something for internal use, fpor those backends that need it (and indeed, it didn't exist when VC only supported CVS, RCS, and SCCS). Stefan