From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Justin Bogner <mail@justinbogner.com>
Cc: emacs-devel@gnu.org
Subject: Re: [patch] vc-find-root with invert
Date: Mon, 21 Jul 2008 22:56:16 -0400 [thread overview]
Message-ID: <jwv4p6imxzo.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <488500C2.8060001@justinbogner.com> (Justin Bogner's message of "Mon, 21 Jul 2008 15:33:54 -0600")
> However, for the other case, we need traverse upwards until we don't
> find the directory, returning the last one that does. As it stands, if
> we don't find the directory we look, we return wherever we started
> searching, which is incorrect.
It's not incorrect at all. It's how CVS and Svn work. They don't have
a "root directory". you may have /foo/baqr/CVS and /foo/CVS, but it
doesn't mean /foo is the root: the two may be simply unrelated.
I.e. it's tryuing to invent something that's simply not there. No other
CVS or Svn front-end does that as far I know. The user specifies the
root he wants to use when it starts vc-dir: Emacs doesn't need to
guess it.
I.e. VC's "root dir" is not something for the UI but something for
internal use, fpor those backends that need it (and indeed, it didn't
exist when VC only supported CVS, RCS, and SCCS).
Stefan
next prev parent reply other threads:[~2008-07-22 2:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 17:24 [patch] vc-find-root with invert Justin Bogner
2008-07-04 18:02 ` Stefan Monnier
2008-07-04 18:06 ` Justin Bogner
2008-07-04 19:52 ` Stefan Monnier
2008-07-05 7:21 ` tomas
2008-07-21 16:27 ` Justin Bogner
2008-07-21 18:32 ` Stefan Monnier
2008-07-21 21:33 ` Justin Bogner
2008-07-21 22:00 ` David Kastrup
2008-07-21 22:23 ` Justin Bogner
2008-07-21 23:02 ` David Kastrup
2008-07-23 4:35 ` Justin Bogner
2008-07-23 19:35 ` Stefan Monnier
2008-07-22 2:56 ` Stefan Monnier [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-07-04 17:47 Justin Bogner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4p6imxzo.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=mail@justinbogner.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.