From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: VC Development Date: Sun, 01 Feb 2009 16:33:16 -0500 Message-ID: References: <18820.57748.262639.494922@kahikatea.snap.net.nz> <8763ju6gh9.fsf@cyd.mit.edu> <200902010602.n11620Ek019863@rodan.ics.uci.edu> <18821.23162.152202.54979@kahikatea.snap.net.nz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1233594998 26083 80.91.229.12 (2 Feb 2009 17:16:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Feb 2009 17:16:38 +0000 (UTC) Cc: Chong Yidong , Dan Nicolaescu , emacs-devel@gnu.org To: Nick Roberts Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 02 18:17:51 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LU2QU-000555-1S for ged-emacs-devel@m.gmane.org; Mon, 02 Feb 2009 18:17:38 +0100 Original-Received: from localhost ([127.0.0.1]:35145 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LU2PB-00023n-7g for ged-emacs-devel@m.gmane.org; Mon, 02 Feb 2009 12:16:17 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LU2IE-0003Oi-Ns for emacs-devel@gnu.org; Mon, 02 Feb 2009 12:09:06 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LU2ID-0003NV-2t for emacs-devel@gnu.org; Mon, 02 Feb 2009 12:09:06 -0500 Original-Received: from [199.232.76.173] (port=43030 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LU2IC-0003NO-Hu for emacs-devel@gnu.org; Mon, 02 Feb 2009 12:09:04 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:29603 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LU2IC-0000Zk-93 for emacs-devel@gnu.org; Mon, 02 Feb 2009 12:09:04 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AswEAD+3hknO+IQk/2dsb2JhbACBbsozhBQGgmw X-IronPort-AV: E=Sophos;i="4.37,366,1231131600"; d="scan'208";a="33208392" Original-Received: from 206-248-132-36.dsl.teksavvy.com (HELO ceviche.home) ([206.248.132.36]) by ironport2-out.teksavvy.com with ESMTP; 02 Feb 2009 12:09:03 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 38017B410A; Sun, 1 Feb 2009 16:33:16 -0500 (EST) In-Reply-To: <18821.23162.152202.54979@kahikatea.snap.net.nz> (Nick Roberts's message of "Sun, 1 Feb 2009 21:16:58 +1300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:108593 Archived-At: >> + (let ((map vc-dir-mode-map)) > OK. I see now that I should have used copy-keymap: > (let ((map (copy-keymap vc-dir-mode-map))) Actually, it should inherit instead: (let ((map (make-sparse-keymap))) (set-keymap-parent map vc-dir-mode-map) Better yet: use the `keymap' property rather than the `local-map' property, so the keymap can just contains the `mouse-2' binding without having to explicitly copy and/or inherit from the local map. > I would like to see this change go in before the pretest. Since I'm > evidently in Dan's killfile this must be a request to the maintainers. > In case there is any confusion, with my proposed change, mouse-2 still > toggles the mark when clicked over the status (first mouse highlight > region) but over the filename (second mouse highlight region) now > visits that file in another buffer. Yes, it's a change we want to have installed. > I would also like to see stay-local behaviour working. I can look at > making vc-svn-registered not use "svn status -v DIR", so that > vc-stay-local-p is not so slow, but clearly it is not worthwhile if > Dan is going to revert all my changes and refuse to discuss the > reasons why. Just send your patches here for approval. Stefan