From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Chong Yidong <cyd@stupidchicken.com>,
Dan Nicolaescu <dann@ics.uci.edu>,
emacs-devel@gnu.org
Subject: Re: VC Development
Date: Sun, 01 Feb 2009 16:33:16 -0500 [thread overview]
Message-ID: <jwv4ozdam42.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <18821.23162.152202.54979@kahikatea.snap.net.nz> (Nick Roberts's message of "Sun, 1 Feb 2009 21:16:58 +1300")
>> + (let ((map vc-dir-mode-map))
> OK. I see now that I should have used copy-keymap:
> (let ((map (copy-keymap vc-dir-mode-map)))
Actually, it should inherit instead:
(let ((map (make-sparse-keymap)))
(set-keymap-parent map vc-dir-mode-map)
Better yet: use the `keymap' property rather than the `local-map'
property, so the keymap can just contains the `mouse-2' binding without
having to explicitly copy and/or inherit from the local map.
> I would like to see this change go in before the pretest. Since I'm
> evidently in Dan's killfile this must be a request to the maintainers.
> In case there is any confusion, with my proposed change, mouse-2 still
> toggles the mark when clicked over the status (first mouse highlight
> region) but over the filename (second mouse highlight region) now
> visits that file in another buffer.
Yes, it's a change we want to have installed.
> I would also like to see stay-local behaviour working. I can look at
> making vc-svn-registered not use "svn status -v DIR", so that
> vc-stay-local-p is not so slow, but clearly it is not worthwhile if
> Dan is going to revert all my changes and refuse to discuss the
> reasons why.
Just send your patches here for approval.
Stefan
next prev parent reply other threads:[~2009-02-01 21:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 23:41 VC Development Nick Roberts
2009-02-01 2:25 ` Chong Yidong
2009-02-01 6:02 ` Dan Nicolaescu
2009-02-01 8:16 ` Nick Roberts
2009-02-01 14:25 ` Chong Yidong
2009-02-01 19:47 ` Nick Roberts
2009-02-01 21:33 ` Stefan Monnier [this message]
2009-02-04 9:34 ` Nick Roberts
2009-02-04 19:31 ` Stefan Monnier
2009-02-05 6:54 ` Nick Roberts
2009-02-05 21:01 ` Stefan Monnier
2009-02-01 21:22 ` Stefan Monnier
2009-02-02 18:44 ` Dan Nicolaescu
2009-02-02 21:15 ` Stefan Monnier
2009-02-03 7:39 ` Nick Roberts
2009-02-01 2:41 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4ozdam42.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=cyd@stupidchicken.com \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.