From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ken Raeburn <raeburn@raeburn.org>
Cc: 3892@emacsbugs.donarmstrong.com
Subject: bug#3892: corrupting load-in-progress value with "let"
Date: Tue, 21 Jul 2009 12:27:05 -0400 [thread overview]
Message-ID: <jwv4ot69f4z.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <47712C91-B427-4C1C-8731-F8BE9463A4A3@raeburn.org> (Ken Raeburn's message of "Tue, 21 Jul 2009 00:01:12 -0400")
> The variable load-in-progress is defined in the C code with DEFVAR_BOOL
> applied to an int variable. Since file loading can be invoked recursively,
> the int value is incremented and decremented when loading begins and ends,
> and should in theory be zero only when no file is being loaded.
> However, if we're loading a .el file from source, the C code in
> lread.c:Fload calls out to the load-source-file-function, which winds up
> calling code in mule.el, which uses "let" on load-in-progress.
> The let/unwind support doesn't save and restore the integer value for
> a Lisp_Misc_Boolfwd variable, just the boolean state. So after loading of
> test3.el finishes above, load-in-progress is restored from its old
> *boolean* value, and gets the value 1 instead of 2 as it should have.
> When test2.elc is done loading, it drops to zero and it looks like we're
> not currently loading any files, even though we're in the middle of loading
> test.elc still.
Good catch.
> On the assumption that DEFVAR_BOOL variables really ought to just be used as
> booleans (I haven't checked other boolean variables though), and we don't
> want to change the Lisp-visible binding to an integer (or "if
> load-in-progress" would stop working right), I'm working on a patch to make
> load-in-progress an actual boolean, and put the file-
> loading depth counter elsewhere, inaccessible to Lisp (since it's
> inaccessible now).
I think we should drop the counter altogether, and use specbind instead.
Stefan
next prev parent reply other threads:[~2009-07-21 16:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87fxbslllh.fsf@cyd.mit.edu>
2009-07-21 4:01 ` bug#3892: corrupting load-in-progress value with "let" Ken Raeburn
2009-07-21 16:27 ` Stefan Monnier [this message]
2009-07-21 18:44 ` Ken Raeburn
2009-07-24 0:08 ` Ken Raeburn
2009-07-24 1:14 ` Stefan Monnier
2009-07-24 1:51 ` Ken Raeburn
2009-08-15 23:15 ` bug#3892: marked as done (corrupting load-in-progress value with "let") Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4ot69f4z.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=3892@emacsbugs.donarmstrong.com \
--cc=raeburn@raeburn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.