From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Date: Mon, 17 Aug 2009 22:56:44 -0400 Message-ID: References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> <19075.22351.611859.436166@winooski.ccs.neu.edu> <873a7sy73p.fsf@mail.jurta.org> <19079.19475.169507.668553@winooski.ccs.neu.edu> <8763cn1bne.fsf@mail.jurta.org> <87ws52xhpi.fsf@mail.jurta.org> Reply-To: Stefan Monnier , 4117@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1250797726 25884 80.91.229.12 (20 Aug 2009 19:48:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Aug 2009 19:48:46 +0000 (UTC) Cc: Eli Barzilay , 4117@emacsbugs.donarmstrong.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 20 21:48:38 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MeDce-0001w5-6l for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Aug 2009 21:48:32 +0200 Original-Received: from localhost ([127.0.0.1]:33104 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeDcd-0002YE-O2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Aug 2009 15:48:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MeDbn-0001wH-R5 for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 15:47:40 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MeDbi-0001pS-1x for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 15:47:38 -0400 Original-Received: from [199.232.76.173] (port=33855 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeDbh-0001pL-VJ for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 15:47:33 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:46120) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MeDbh-0002SM-Ag for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 15:47:33 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7KJkpLN004437; Thu, 20 Aug 2009 12:47:29 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n7KJcdqn002472; Thu, 20 Aug 2009 12:38:39 -0700 Resent-Date: Thu, 20 Aug 2009 12:38:39 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 20 Aug 2009 19:38:38 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4117 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4117-submit@emacsbugs.donarmstrong.com id=B4117.1250564212648 (code B ref 4117); Thu, 20 Aug 2009 19:38:38 +0000 Original-Received: (at 4117) by emacsbugs.donarmstrong.com; 18 Aug 2009 02:56:52 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7I2uoDx000639 for <4117@emacsbugs.donarmstrong.com>; Mon, 17 Aug 2009 19:56:52 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtgEAB+1iUpFpZNo/2dsb2JhbACBUtUohBkFh0k X-IronPort-AV: E=Sophos;i="4.43,399,1246852800"; d="scan'208";a="43700511" Original-Received: from 69-165-147-104.dsl.teksavvy.com (HELO ceviche.home) ([69.165.147.104]) by ironport2-out.teksavvy.com with ESMTP; 17 Aug 2009 22:56:12 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 1B597B407B; Mon, 17 Aug 2009 22:56:45 -0400 (EDT) In-Reply-To: <87ws52xhpi.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 18 Aug 2009 00:18:17 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Thu, 20 Aug 2009 15:47:38 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30322 Archived-At: > Actually the solution is much simpler. I just noticed that > `read-key-sequence' already has the necessary argument > `dont-downcase-last': > The third (optional) arg dont-downcase-last, if non-nil, means do not > convert the last event to lower case. (Normally any upper case event > is converted to lower case if the original event is undefined and the lower > case equivalent is defined.) A non-nil value is appropriate for reading > a key sequence to be defined. Yes, I guess that's better. But at the same time, it still seems incorrect: the sequence we get has gone through input-decode-map, function-key-map, key-translation-map, keyboard-translate-table, down-mouse and drag-mouse event may have been dropped, etc... So stuffing it back into unread-command-events is incorrect. I think the right solution requires the use of something like this-single-command-raw-keys. Stefan