bug#4671: `read-passwd' does not recognize keypad enter key

bug#4671: `read-passwd' does not recognize keypad enter key

[Michael Ernst]

My Kinesis keyboard's "enter" key is read by Emacs as kp-enter.  As a
result, the enter key does not terminate a password as read by
`read-passwd'.  This patch corrects that problem.

                    -Michael Ernst

Changelog entry:

2009-10-08  Michael Ernst  <mernst@alum.mit.edu>

	* subr.el (read-passwd): Add 'kp-enter to stop-keys.


--- /homes/gws/mernst/bin/src/emacs-22/Linux-i686/emacs/lisp/subr.el	2009-10-01 10:47:42.000000000 -0700
+++ -	2009-10-07 22:31:51.839795567 -0700
@@ -1940,7 +1940,7 @@
 	    (echo-keystrokes 0)
 	    (cursor-in-echo-area t)
 	    (message-log-max nil)
-	    (stop-keys (list 'return ?\r ?\n ?\e))
+	    (stop-keys (list 'return ?\r ?\n ?\e 'kp-enter))
 	    (rubout-keys (list 'backspace ?\b ?\177)))
 	(add-text-properties 0 (length prompt)
 			     minibuffer-prompt-properties prompt)

bug#4671: `read-passwd' does not recognize keypad enter key

[Stefan Monnier]

> My Kinesis keyboard's "enter" key is read by Emacs as kp-enter.

Which version of Emacs is that?
I've installed a few weeks ago a patch that makes read-passwd use the
read-key rather than read-char, so AFAIK such problems should have
been fixed.


        Stefan

bug#4671: `read-passwd' does not recognize keypad enter key

[Michael Ernst]

> Which version of Emacs is that?
> I've installed a few weeks ago a patch that makes read-passwd use the
> read-key rather than read-char, so AFAIK such problems should have
> been fixed.

My patch was against the latest CVS version.  (I would have mentioned the
version otherwise, but I should have mentioned it even then; sorry for the
omission.)

I noticed the problem in Debian's emacs-snapshot package:

GNU Emacs 23.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.16.1) of 2009-07-31 on lansones, modified by Debian

                    -Michael Ernst

bug#4671: `read-passwd' does not recognize keypad enter key

[Stefan Monnier]

>> Which version of Emacs is that?
>> I've installed a few weeks ago a patch that makes read-passwd use the
>> read-key rather than read-char, so AFAIK such problems should have
>> been fixed.

> My patch was against the latest CVS version.  (I would have mentioned the
> version otherwise, but I should have mentioned it even then; sorry for the
> omission.)

That's very odd.  What does M-: (read-key) RET <kp-enter> return?
What about C-h k <kp-enter> ?


        Stefan

bug#4671: `read-passwd' does not recognize keypad enter key

[Michael Ernst]

Stefan-

As I mentioned, I am running the Ubuntu emacs-snapshot version (but I
submitted a patch against the CVS version, assuming the two wouldn't be
much different).  Perhaps the explanation is that it had not yet
incorporated your latest patch.  In any event, my version does not have the
`read-key' function.  I'll re-submit if the problem persists in the next
official Emacs release.

                    -Mike