all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: "Andreas Röhler" <andreas.roehler@online.de>,
	"Stephen J. Turnbull" <stephen@xemacs.org>,
	emacs-devel@gnu.org,
	"Lennart Borgman" <lennart.borgman@gmail.com>,
	"Antoine Levitt" <antoine.levitt@gmail.com>
Subject: Re: Errors in interactive commands
Date: Wed, 03 Aug 2011 10:41:34 -0400	[thread overview]
Message-ID: <jwv4o1ywoh9.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m3d3gm7rqk.fsf@hase.home> (Andreas Schwab's message of "Wed, 03 Aug 2011 11:45:55 +0200")

>> Examples such like this one is why I propose using something like
>> (throw 'command-level) instead of raising an error.
> How would that change anything, apart from breaking code that tries to
> catch the error?  Raising an error throws to top-level by default
> anyway.

Exactly.  I think signalling errors is not a bad approach, tho it should
be improved to use `user-error' rather than just `error' for cases which
are normally associated with user errors (which are usually listed in
debug-ignored-errors).  This way we won't need as many regexps in
debug-ignored-errors.

As for the difference between signalling errors and returning nil, they
are fundamentally equivalent, so it's really a question of which is more
convenient "in typical cases".
More consistency would be good, but since any changes in this area risk
introducing backward compatibility problems, I'm strongly in favor of
leaving things as they are.


        Stefan



  reply	other threads:[~2011-08-03 14:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-02 17:46 Errors in interactive commands Antoine Levitt
2011-08-02 19:04 ` Andreas Röhler
2011-08-02 19:15 ` Lennart Borgman
2011-08-02 19:18   ` Lars Magne Ingebrigtsen
2011-08-03  7:13   ` Stephen J. Turnbull
2011-08-03  9:28     ` Lennart Borgman
2011-08-02 19:25 ` Stefan Monnier
2011-08-02 19:36   ` Lennart Borgman
2011-08-03  6:13     ` Andreas Röhler
2011-08-03  7:28       ` Stephen J. Turnbull
2011-08-03  7:46         ` Andreas Röhler
2011-08-03  8:08           ` David Kastrup
2011-08-03  8:34             ` Andreas Röhler
2011-08-03  9:09           ` Stephen J. Turnbull
2011-08-03 10:31             ` Andreas Röhler
2011-08-04  2:15               ` Stephen J. Turnbull
2011-08-03  9:37         ` Lennart Borgman
2011-08-03  9:45           ` Andreas Schwab
2011-08-03 14:41             ` Stefan Monnier [this message]
2011-08-03 15:01               ` Lennart Borgman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv4o1ywoh9.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=andreas.roehler@online.de \
    --cc=antoine.levitt@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=lennart.borgman@gmail.com \
    --cc=schwab@linux-m68k.org \
    --cc=stephen@xemacs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.