all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: JC Petkovich <jcpetkovich@gmail.com>
Cc: 11966@debbugs.gnu.org
Subject: bug#11966: 24.1; cperl-mode with evil-mode causes hang on syntax-propertize
Date: Wed, 18 Jul 2012 03:28:11 -0400	[thread overview]
Message-ID: <jwv4np55y54.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAPrF3-CP1Ab+yyDYKBk2QnZeKOpUowyKrfGgi2EWpifLbqeAMg@mail.gmail.com> (JC Petkovich's message of "Tue, 17 Jul 2012 15:04:04 -0400")

> Emacs hangs on the creation of a newline with evil-ret when in a cperl
> buffer with some POD documentation after the __END__. This doesn't
> appear to be a bug in evil, but instead a bug in cperl or
> syntax-propertize,
> but I can't tell for sure.

Before I dive further into this, can you first check whether the bug-fix
for bug#11739 (see patch below) happens to fix your problem as well?


        Stefan


=== modified file 'lisp/progmodes/cperl-mode.el'
--- lisp/progmodes/cperl-mode.el	2012-01-19 07:21:25 +0000
+++ lisp/progmodes/cperl-mode.el	2012-07-06 20:57:58 +0000
@@ -8951,14 +8951,15 @@
       (setq cperl-syntax-done-to (min cperl-syntax-done-to beg))))
 
 (defun cperl-update-syntaxification (from to)
-  (if (and cperl-use-syntax-table-text-property
-	   cperl-syntaxify-by-font-lock
-	   (or (null cperl-syntax-done-to)
-	       (< cperl-syntax-done-to to)))
-      (progn
-	(save-excursion
-	  (goto-char from)
-	  (cperl-fontify-syntaxically to)))))
+  (cond
+   ((not cperl-use-syntax-table-text-property) nil)
+   ((fboundp 'syntax-propertize) (syntax-propertize to))
+   ((and cperl-syntaxify-by-font-lock
+         (or (null cperl-syntax-done-to)
+             (< cperl-syntax-done-to to)))
+    (save-excursion
+      (goto-char from)
+      (cperl-fontify-syntaxically to)))))
 
 (defvar cperl-version
   (let ((v  "Revision: 6.2"))






  reply	other threads:[~2012-07-18  7:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-17 19:04 bug#11966: 24.1; cperl-mode with evil-mode causes hang on syntax-propertize JC Petkovich
2012-07-18  7:28 ` Stefan Monnier [this message]
2012-07-18  7:41   ` JC Petkovich
2012-07-18  9:35 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv4np55y54.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=11966@debbugs.gnu.org \
    --cc=jcpetkovich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.