From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111661: * progmodes/compile.el (compilation-start-hook): Simplify docstring. Date: Sat, 02 Feb 2013 10:29:53 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1359819007 6539 80.91.229.3 (2 Feb 2013 15:30:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Feb 2013 15:30:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: Christopher Schmidt Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 02 16:30:27 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U1f2u-0006Oe-Db for ged-emacs-devel@m.gmane.org; Sat, 02 Feb 2013 16:30:24 +0100 Original-Received: from localhost ([::1]:53859 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1f2b-0007Cj-1R for ged-emacs-devel@m.gmane.org; Sat, 02 Feb 2013 10:30:05 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1f2X-0007BS-LO for emacs-devel@gnu.org; Sat, 02 Feb 2013 10:30:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U1f2S-00040u-91 for emacs-devel@gnu.org; Sat, 02 Feb 2013 10:30:01 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:57536) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1f2S-00040k-1G for emacs-devel@gnu.org; Sat, 02 Feb 2013 10:29:56 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFpZnt/2dsb2JhbABEvw4Xc4IfAQVWIxALNAcLFBgNJIgkwS2RCgOIYZwZgV6DFQ X-IPAS-Result: Av4EABK/CFFFpZnt/2dsb2JhbABEvw4Xc4IfAQVWIxALNAcLFBgNJIgkwS2RCgOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="277067" Original-Received: from 69-165-153-237.dsl.teksavvy.com (HELO pastel.home) ([69.165.153.237]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 02 Feb 2013 10:29:54 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id C6F295943E; Sat, 2 Feb 2013 10:29:53 -0500 (EST) In-Reply-To: (Christopher Schmidt's message of "Sat, 02 Feb 2013 07:25:20 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156798 Archived-At: > - "List of hook functions run by `compilation-start' on the compilation process. > -\(See `run-hook-with-args'). > -If you use \"omake -P\" and do not want \\[save-buffers-kill-terminal] to ask whether you want > -the compilation to be killed, you can use this hook: > - (add-hook 'compilation-start-hook > - (lambda (process) (set-process-query-on-exit-flag process nil)) nil t)" > + "Hook run after starting a new compilation process. The hook > +is run with one argument, the new process." I like part of this simplification, but the first line of a docstring should "stand on its own" (i.e. it shouldn't end in the middle of a sentence). In this case, the best is to cut the line between "process." and "The hook". Stefan