From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13687: 24.3.50; `read-regexp' should provide regex for symbol at point as defaults Date: Fri, 15 Feb 2013 10:41:06 -0500 Message-ID: References: <87r4kn5ppo.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT X-Trace: ger.gmane.org 1360942910 29407 80.91.229.3 (15 Feb 2013 15:41:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Feb 2013 15:41:50 +0000 (UTC) Cc: 13687@debbugs.gnu.org To: Jambunathan K Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 15 16:42:10 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U6NQM-0000IA-NR for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Feb 2013 16:42:06 +0100 Original-Received: from localhost ([::1]:37801 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6NQ2-0005Qq-TN for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Feb 2013 10:41:46 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6NPi-0004gl-Fe for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 10:41:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U6NPc-0005x6-An for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 10:41:26 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6NPb-0005wq-Va for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 10:41:19 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U6NQI-0002pZ-Oc for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 10:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Feb 2013 15:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13687 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13687-submit@debbugs.gnu.org id=B13687.136094291210865 (code B ref 13687); Fri, 15 Feb 2013 15:42:02 +0000 Original-Received: (at 13687) by debbugs.gnu.org; 15 Feb 2013 15:41:52 +0000 Original-Received: from localhost ([127.0.0.1]:57808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6NQ8-0002pB-CO for submit@debbugs.gnu.org; Fri, 15 Feb 2013 10:41:52 -0500 Original-Received: from relais.videotron.ca ([24.201.245.36]:9215) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6NQ6-0002p5-M7 for 13687@debbugs.gnu.org; Fri, 15 Feb 2013 10:41:50 -0500 Original-Received: from ceviche.home ([24.201.208.110]) by VL-VM-MR005.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MI900C6CQ8IQZ40@VL-VM-MR005.ip.videotron.ca> for 13687@debbugs.gnu.org; Fri, 15 Feb 2013 10:41:06 -0500 (EST) Original-Received: by ceviche.home (Postfix, from userid 20848) id 7870666109; Fri, 15 Feb 2013 10:41:06 -0500 (EST) In-reply-to: <87r4kn5ppo.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:71315 Archived-At: > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11095 > `read-regexp' should provide regex for symbol at point as one of the > defaults. This should be the first of defaults while in any of the > progmodes. I disagree: read-regexp is a generic function which can be used in various contexts, some of which might not care at all about the text around point. So the caller should have control over the first default (of course, it's perfectly fine to always add the current tag in the subsequent defaults). This said your patch seems to leave the caller's provided `defaults' at the beginning of the minibuffer's `defaults', so I think your patch is fine, feel free to install it. Stefan