From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14995: [PATCH] vc-do-command ignores symbolic links Date: Wed, 31 Jul 2013 10:13:23 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1375280063 5256 80.91.229.3 (31 Jul 2013 14:14:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 31 Jul 2013 14:14:23 +0000 (UTC) Cc: 14995@debbugs.gnu.org To: Xue Fuqiao Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 31 16:14:24 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V4XAV-0002AY-7Y for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Jul 2013 16:14:23 +0200 Original-Received: from localhost ([::1]:37909 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4XAU-0007Pw-ML for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Jul 2013 10:14:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4XAJ-0007Ov-Uc for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2013 10:14:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4XAA-0005BJ-Ps for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2013 10:14:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4XAA-0005B1-NS for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2013 10:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1V4XAA-0007uh-8W for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2013 10:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Jul 2013 14:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14995 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14995-submit@debbugs.gnu.org id=B14995.137528001130361 (code B ref 14995); Wed, 31 Jul 2013 14:14:02 +0000 Original-Received: (at 14995) by debbugs.gnu.org; 31 Jul 2013 14:13:31 +0000 Original-Received: from localhost ([127.0.0.1]:60992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V4X9f-0007td-2G for submit@debbugs.gnu.org; Wed, 31 Jul 2013 10:13:31 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:17080) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V4X9d-0007tL-65 for 14995@debbugs.gnu.org; Wed, 31 Jul 2013 10:13:29 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpZvt/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av8EABK/CFFFpZvt/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="20244823" Original-Received: from 69-165-155-237.dsl.teksavvy.com (HELO pastel.home) ([69.165.155.237]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 31 Jul 2013 10:13:17 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 1111963C70; Wed, 31 Jul 2013 10:13:23 -0400 (EDT) In-Reply-To: (Xue Fuqiao's message of "Wed, 31 Jul 2013 18:53:42 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:76855 Archived-At: > This small patch fixes a bug in vc-do-command: > === modified file 'lisp/vc/vc-dispatcher.el' > --- lisp/vc/vc-dispatcher.el 2013-06-15 02:50:47 +0000 > +++ lisp/vc/vc-dispatcher.el 2013-07-31 10:49:27 +0000 > @@ -275,11 +275,8 @@ > that is inserted into the command line before the filename. > Return the return value of the slave command in the synchronous > case, and the process object in the asynchronous case." > - ;; FIXME: file-relative-name can return a bogus result because > - ;; it doesn't look at the actual file-system to see if symlinks > - ;; come into play. > (let* ((files > - (mapcar (lambda (f) (file-relative-name (expand-file-name f))) > + (mapcar (lambda (f) (file-relative-name (file-truename > (expand-file-name f)))) > (if (listp file-or-list) file-or-list (list file-or-list)))) > (full-command > ;; What we're doing here is preparing a version of the command I'm not completely sure this fix is needed (and I'd rather avoid calling file-truename, if possible). Do you have a concrete case where this causes problems? Stefan