Inclusion of websocket library

Inclusion of websocket library

[Andrew Hyatt]

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

Hi everyone,

I have a websocket library (https://github.com/ahyatt/emacs-websocket),
which has been pretty stable for a while now.  It implements the latest
websocket protocol, RFC 6455.

I'm wondering if it anyone thinks this should just be part of the emacs
distribution (probably under the "net" directory).  I personally think that
library-type modules such as this should just be included in emacs, but
there isn't anything particularly wrong with it being available via ELPA as
it is now.

I'd be happy to send a patch adding this in if people think it's a good
idea.  I have FSF papers, the code compiles cleanly (except for the ert
tests, which need the dynamic scope of flet), and it works.

[-- Attachment #2: Type: text/html, Size: 955 bytes --]

Re: Inclusion of websocket library

[Stefan Monnier]

> I'm wondering if it anyone thinks this should just be part of the emacs
> distribution (probably under the "net" directory).  I personally think that
> library-type modules such as this should just be included in emacs, but
> there isn't anything particularly wrong with it being available via ELPA as
> it is now.

It sounds like something that should definitely be in GNU ELPA if you're
willing to maintain it from there.  Maybe even in Emacs proper, tho I'd
have to think a bit more about it.


        Stefan "out of town"

Re: Inclusion of websocket library

[Andrew Hyatt]

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]

What is involved is putting this on GNU ELPA?  I can certain do that, and
maintain it there, but since my package is already available via Marmalade,
it is already available via an ELPA that (I think) most ELPA-users are
using.  Is there a further advantage to putting this on the GNU ELPA
specifically?


On Wed, Jul 10, 2013 at 4:32 AM, Stefan Monnier <monnier@iro.umontreal.ca>wrote:

> > I'm wondering if it anyone thinks this should just be part of the emacs
> > distribution (probably under the "net" directory).  I personally think
> that
> > library-type modules such as this should just be included in emacs, but
> > there isn't anything particularly wrong with it being available via ELPA
> as
> > it is now.
>
> It sounds like something that should definitely be in GNU ELPA if you're
> willing to maintain it from there.  Maybe even in Emacs proper, tho I'd
> have to think a bit more about it.
>
>
>         Stefan "out of town"
>

[-- Attachment #2: Type: text/html, Size: 1357 bytes --]

Re: Inclusion of websocket library

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

GNU ELPA is the only repo that's enabled out of the box, so I call this an
advantage over the alternatives :-) On an unrelated note - I'm pretty sure
MELPA has about as many users as Marmalade, but I think your library is
available there as well.


On 12 July 2013 08:29, Andrew Hyatt <ahyatt@gmail.com> wrote:

> What is involved is putting this on GNU ELPA?  I can certain do that, and
> maintain it there, but since my package is already available via Marmalade,
> it is already available via an ELPA that (I think) most ELPA-users are
> using.  Is there a further advantage to putting this on the GNU ELPA
> specifically?
>
>
> On Wed, Jul 10, 2013 at 4:32 AM, Stefan Monnier <monnier@iro.umontreal.ca>wrote:
>
>> > I'm wondering if it anyone thinks this should just be part of the emacs
>> > distribution (probably under the "net" directory).  I personally think
>> that
>> > library-type modules such as this should just be included in emacs, but
>> > there isn't anything particularly wrong with it being available via
>> ELPA as
>> > it is now.
>>
>> It sounds like something that should definitely be in GNU ELPA if you're
>> willing to maintain it from there.  Maybe even in Emacs proper, tho I'd
>> have to think a bit more about it.
>>
>>
>>         Stefan "out of town"
>>
>
>

[-- Attachment #2: Type: text/html, Size: 2024 bytes --]

Re: Inclusion of websocket library

[Stefan Monnier]

> What is involved is putting this on GNU ELPA?

Mostly, signing copyright paperwork.

> I can certain do that, and maintain it there, but since my package is
> already available via Marmalade, it is already available via an ELPA
> that (I think) most ELPA-users are using.  Is there a further
> advantage to putting this on the GNU ELPA specifically?

Some advantages:
- the GNU ELPA archive is the only archive that's configured by default,
  so you can tell people to M-x package-install without worrying about
  whether or not they've added Marmalade to their config.
- the code uses the same copyright rules as Emacs code, so that we can
  easily move code between the two.  IOW it'd be ready for inclusion in
  Emacs proper.
- all Emacs maintainers have write access to the code, so it can benefit
  from random cleanups or adjustments to new features.


        Stefan

Re: Inclusion of websocket library

[Andrew Hyatt]

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

OK, sounds like a good thing. How do I go about uploading my code to GNU
ELPA, and keeping it updated?
On Jul 31, 2013 12:25 AM, "Stefan Monnier" <monnier@iro.umontreal.ca> wrote:

> > What is involved is putting this on GNU ELPA?
>
> Mostly, signing copyright paperwork.
>
> > I can certain do that, and maintain it there, but since my package is
> > already available via Marmalade, it is already available via an ELPA
> > that (I think) most ELPA-users are using.  Is there a further
> > advantage to putting this on the GNU ELPA specifically?
>
> Some advantages:
> - the GNU ELPA archive is the only archive that's configured by default,
>   so you can tell people to M-x package-install without worrying about
>   whether or not they've added Marmalade to their config.
> - the code uses the same copyright rules as Emacs code, so that we can
>   easily move code between the two.  IOW it'd be ready for inclusion in
>   Emacs proper.
> - all Emacs maintainers have write access to the code, so it can benefit
>   from random cleanups or adjustments to new features.
>
>
>         Stefan
>

[-- Attachment #2: Type: text/html, Size: 1481 bytes --]

Re: Inclusion of websocket library

[Stefan Monnier]

> OK, sounds like a good thing.  How do I go about uploading my code to
> GNU ELPA,

Currently, we simply add the file to the `elpa' branch (more
specifically in a new elpa/packages/websocket directory), after which it
should magically appear (a day later) in the GNU ELPA.

> and keeping it updated?

We give you write access to the Emacs repository (which includes the
`elpa' branch).


        Stefan

Re: Inclusion of websocket library

[Andrew Hyatt]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

Sounds good, I'm willing to do this.  Thanks for explaining.


On Wed, Jul 31, 2013 at 1:55 PM, Stefan Monnier <monnier@iro.umontreal.ca>wrote:

> > OK, sounds like a good thing.  How do I go about uploading my code to
> > GNU ELPA,
>
> Currently, we simply add the file to the `elpa' branch (more
> specifically in a new elpa/packages/websocket directory), after which it
> should magically appear (a day later) in the GNU ELPA.
>
> > and keeping it updated?
>
> We give you write access to the Emacs repository (which includes the
> `elpa' branch).
>
>
>         Stefan
>

[-- Attachment #2: Type: text/html, Size: 1024 bytes --]

Re: Inclusion of websocket library

[Stefan Monnier]

> Sounds good, I'm willing to do this.  Thanks for explaining.

I just added those files to the `elpa' branch (with a few minor changes).

To get write access, please request to be a member of the "emacs" group,
from your Savannah account.


        Stefan