bug#16085: 24.3.50; electric-pair-mode and cua-mode clash when autowrapping region

bug#16085: 24.3.50; electric-pair-mode and cua-mode clash when autowrapping region

[João Távora]

Hello maintainers,

    emacs -Q
    M-x cua-mode
    M-x electric-pair-mode
    insert foo
    select region "foo"
    press "("
    should get "(foo)", get ")(" instead.

This is a problem I solved in my third-party autopair.el library using
this horrible code

    (defun autopair--should-autowrap ()
      (and autopair-mode
           (not (eq this-command 'autopair-backspace))
           (symbolp this-command)
           (string-match "^autopair" (symbol-name this-command))
           (autopair--calculate-wrap-action)))
     
    (defadvice cua--pre-command-handler-1 (around autopair-override activate)
      "Don't actually do anything if autopair is about to autowrap. "
      (unless (autopair--should-autowrap) ad-do-it))
     
    ;; aparently not needed for electric.el since it works ok with delete-selectrion-mode
    ;; 
    ;; (defadvice delete-selection-pre-hook (around autopair-override activate)
    ;;   "Don't actually do anything if autopair is  about to autowrap. "
    ;;   (unless (autopair--should-autowrap) ad-do-it))

Thanks,
João

bug#16085: 24.3.50; electric-pair-mode and cua-mode clash when autowrapping region

[Stefan Monnier]

> Hello maintainers,
>     emacs -Q
>     M-x cua-mode
>     M-x electric-pair-mode
>     insert foo
>     select region "foo"
>     press "("
>     should get "(foo)", get ")(" instead.

> This is a problem I solved in my third-party autopair.el library using
> this horrible code

That's a problem we already solved for delete-selection-mode (see patch
below).  So we just need to port this fix to cua-mode.  Even better
is to make cua-mode use delete-selection-mode.

I installed a patch which does that.


        Stefan