From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r115470: eww: exit and close actions Date: Thu, 12 Dec 2013 13:52:48 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1386874443 10151 80.91.229.3 (12 Dec 2013 18:54:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 12 Dec 2013 18:54:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 12 19:54:08 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VrBOi-0008SM-H7 for ged-emacs-devel@m.gmane.org; Thu, 12 Dec 2013 19:54:08 +0100 Original-Received: from localhost ([::1]:38213 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrBOi-0000VF-7X for ged-emacs-devel@m.gmane.org; Thu, 12 Dec 2013 13:54:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrBOY-0000Hc-Pq for emacs-devel@gnu.org; Thu, 12 Dec 2013 13:54:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrBON-0002Us-GN for emacs-devel@gnu.org; Thu, 12 Dec 2013 13:53:58 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:41160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrBON-0002Ua-BD for emacs-devel@gnu.org; Thu, 12 Dec 2013 13:53:47 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id rBCIrFxi021401; Thu, 12 Dec 2013 13:53:31 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 61398AE350; Thu, 12 Dec 2013 13:52:48 -0500 (EST) In-Reply-To: (Teodor Zlatanov's message of "Wed, 11 Dec 2013 19:00:45 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4790=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4790> : inlines <317> : streams <1089733> : uri <1622058> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166349 Archived-At: > +(defun eww-exit () > + "Exit the Emacs Web Wowser." > + (interactive) > + (setq eww-history nil) > + (kill-buffer (current-buffer))) > + > +(defun eww-close () > + "Close the Emacs Web Wowser browser, leaving history intact." > + (interactive) > + (quit-window)) I think this is a step backward. The names `eww-close' and `eww-exit' don't help the user understand what those commands do. To me they sound like different names for the same thing. I'd rather use commands `kill-this-buffer' and `quit-window' which are much more clear and which the user might already know. I'm not sure how (setq eww-history nil) fits in there, because I don't know why it's there, so I can't comment on how best to go about it in this respect. Stefan