From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#16943: 24.3.50; [PATCH] `icomplete-exhibit' needs `with-current-buffer' for minibuffer Date: Fri, 07 Mar 2014 19:17:32 -0500 Message-ID: References: <5d97809c-5fbf-4b3e-b864-8badfbd532da@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1394237894 9046 80.91.229.3 (8 Mar 2014 00:18:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Mar 2014 00:18:14 +0000 (UTC) Cc: 16943@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 08 01:18:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WM4y5-00051g-T2 for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Mar 2014 01:18:22 +0100 Original-Received: from localhost ([::1]:38819 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WM4y5-00072L-2B for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Mar 2014 19:18:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WM4xu-000724-NC for bug-gnu-emacs@gnu.org; Fri, 07 Mar 2014 19:18:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WM4xn-0001Rk-Ce for bug-gnu-emacs@gnu.org; Fri, 07 Mar 2014 19:18:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WM4xn-0001Rf-8i for bug-gnu-emacs@gnu.org; Fri, 07 Mar 2014 19:18:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WM4xm-0001Ht-OV for bug-gnu-emacs@gnu.org; Fri, 07 Mar 2014 19:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Mar 2014 00:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16943 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16943-submit@debbugs.gnu.org id=B16943.13942378564904 (code B ref 16943); Sat, 08 Mar 2014 00:18:02 +0000 Original-Received: (at 16943) by debbugs.gnu.org; 8 Mar 2014 00:17:36 +0000 Original-Received: from localhost ([127.0.0.1]:55346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WM4xL-0001H1-Vw for submit@debbugs.gnu.org; Fri, 07 Mar 2014 19:17:36 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:10953) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WM4xJ-0001Gs-3d for 16943@debbugs.gnu.org; Fri, 07 Mar 2014 19:17:33 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCppy/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJMEtkQoDiGGcGYFegxU X-IPAS-Result: Av8EABK/CFFMCppy/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJMEtkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="50840587" Original-Received: from 76-10-154-114.dsl.teksavvy.com (HELO ceviche.home) ([76.10.154.114]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 07 Mar 2014 19:17:32 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 370DC660A5; Fri, 7 Mar 2014 19:17:32 -0500 (EST) In-Reply-To: <5d97809c-5fbf-4b3e-b864-8badfbd532da@default> (Drew Adams's message of "Wed, 5 Mar 2014 10:50:07 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86644 Archived-At: > (with-current-buffer (window-buffer (active-minibuffer-window)) I think this would only paper over an underlying problem: icomplete uses a buffer-local post-command-hook, so it makes no sense that it would be run in another buffer. A few possibilities: - the hook is placed in the wrong buffer, in which case it would only be run in the wrong buffer. - an earlier post-command-hook function changed current-buffer. - an earlier minibuffer-setup-hook function changed current-buffer (which would cause the hook to be placed in the wrong buffer). Stefan