From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17348: 24.3.50; Cannot advice-add the same function :before and :after Date: Thu, 01 May 2014 16:47:20 -0400 Message-ID: References: <87vbtwl4sv.fsf@yahoo.fr> <87iopvlu2s.fsf@yahoo.fr> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1398977310 24557 80.91.229.3 (1 May 2014 20:48:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 1 May 2014 20:48:30 +0000 (UTC) Cc: 17348@debbugs.gnu.org To: Nicolas Richard Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 01 22:48:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wfxu2-0004ob-Os for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 May 2014 22:48:22 +0200 Original-Received: from localhost ([::1]:41376 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wfxu2-0002yK-Di for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 May 2014 16:48:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wfxtq-0002yC-SK for bug-gnu-emacs@gnu.org; Thu, 01 May 2014 16:48:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wfxti-0004Xr-Kt for bug-gnu-emacs@gnu.org; Thu, 01 May 2014 16:48:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wfxti-0004Xj-HS for bug-gnu-emacs@gnu.org; Thu, 01 May 2014 16:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wfxti-0002LI-5C for bug-gnu-emacs@gnu.org; Thu, 01 May 2014 16:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 May 2014 20:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17348 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17348-submit@debbugs.gnu.org id=B17348.13989772698978 (code B ref 17348); Thu, 01 May 2014 20:48:02 +0000 Original-Received: (at 17348) by debbugs.gnu.org; 1 May 2014 20:47:49 +0000 Original-Received: from localhost ([127.0.0.1]:47714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WfxtU-0002Kj-G5 for submit@debbugs.gnu.org; Thu, 01 May 2014 16:47:48 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:60719) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WfxtR-0002Ka-Gz for 17348@debbugs.gnu.org; Thu, 01 May 2014 16:47:46 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id A735D2C09A; Thu, 1 May 2014 16:47:44 -0400 (EDT) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id BF49B1E5B89; Thu, 1 May 2014 16:47:20 -0400 (EDT) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id A592AB4125; Thu, 1 May 2014 16:47:20 -0400 (EDT) In-Reply-To: <87iopvlu2s.fsf@yahoo.fr> (Nicolas Richard's message of "Sat, 26 Apr 2014 22:22:19 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88500 Archived-At: > In the actual situation that lead me to adding the same function twice, > it was a tracing function, like (message "time: %s ; value of > foovariable: %s" (current-time) foovariable) and I assumed that I would > be able to remove them both with one (advice-remove ...) -- I guess that > isn't too complicated. Removing them both would not be desirable in general. > OTOH I also think that the current behaviour is fine, but I'd suggest > emitting a warning when an advice is being overwritten/removed that way. It's not meant to be a "secret" behavior, so people should be able to rely on this behavior (just like you can rely on add-hook being idempotent) and use it, in which case emitting a warning is not appropriate. This said, maybe we should make it easier to do what you wanted. E.g. we could probably make it possible to use different `name' properties to let a user add a function several times (potentially at different places, but even at the same place). Stefan