From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Barry OReilly <gundaetiapo@gmail.com>
Cc: 16411 <16411@debbugs.gnu.org>
Subject: bug#16411: undo-only bugs
Date: Thu, 19 Jun 2014 17:35:13 -0400 [thread overview]
Message-ID: <jwv4mzgvbng.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <CAFM41H08EvW3nrrrGbaD3y4YbjY0D1sefPLbTzenSFFSLNLvag@mail.gmail.com> (Barry OReilly's message of "Wed, 28 May 2014 14:42:33 -0400")
> + "The pending undo elements in a run of consecutive undo commands.
> +Specifically, this is a list of assocations of the
> +form (ADJUSTED-ELT . ORIG-UNDO-LIST). ADJUSTED-ELT is an undo
[...]
> - (let ((equiv (gethash pending-undo-list undo-equiv-table)))
> + ;; Check to see whether we're hitting a redo record
> + (let ((equiv (gethash (cdr-safe pending-undo-list) undo-equiv-table)))
Why take the cdr of pending-undo-list? IOW why skip the first element?
Oh, and please punctuate your comments.
> - (setq pending-undo-list equiv)))
> + (setq pending-undo-list (cons (car equiv) equiv))))
I guess this brings the same question as above.
> + (let ((list buffer-undo-list)
> + (new-equiv (cdr-safe pending-undo-list)))
And same here.
> + (when (undo-primitive-elt elt)
> + ;; Map the new undo element to what it undid. Not aware
> + ;; yet of cases where we want to map all new elements.
> + (puthash buffer-undo-list orig-tail undo-redo-table))
We should only do that in those cases where undo-equiv-table can't be
used.
Also, why did you have to move the valid-marker-adjustments thingy out
of undo-primitive-elt?
Stefan
next prev parent reply other threads:[~2014-06-19 21:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 22:33 bug#16411: undo-only bugs Barry OReilly
2014-01-10 23:54 ` Stefan Monnier
2014-01-11 3:48 ` Barry OReilly
2014-01-11 4:29 ` Stefan Monnier
2014-01-11 5:09 ` Barry OReilly
2014-01-14 0:49 ` Stefan Monnier
2014-01-14 1:52 ` Stefan Monnier
2014-01-14 14:00 ` Barry OReilly
2014-01-19 0:58 ` Barry OReilly
2014-01-19 3:18 ` Stefan Monnier
2014-01-19 16:57 ` Barry OReilly
2014-02-14 18:51 ` Barry OReilly
2014-02-14 22:29 ` Barry OReilly
2014-02-18 17:40 ` Barry OReilly
2014-02-26 15:20 ` bug#16411: undo in region corrupts existing text Barry OReilly
2014-02-27 5:02 ` Stefan Monnier
2014-05-13 15:01 ` bug#16411: undo-only bugs Barry OReilly
2014-05-14 18:06 ` Stefan Monnier
2014-05-14 18:45 ` Stefan Monnier
2014-05-14 19:55 ` Stefan Monnier
2014-05-14 21:56 ` Barry OReilly
2014-05-15 2:23 ` Stefan Monnier
2014-05-15 3:51 ` Barry OReilly
2014-05-15 13:00 ` Stefan Monnier
2014-05-28 18:42 ` Barry OReilly
2014-06-19 21:35 ` Stefan Monnier [this message]
2014-05-14 13:32 ` Barry OReilly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4mzgvbng.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=16411@debbugs.gnu.org \
--cc=gundaetiapo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.