From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: 19645@debbugs.gnu.org
Subject: bug#19645: 25.0.50; Recent EIEIO changes broke helm: Lisp error: (cl-no-next-method helm--setup-source...
Date: Wed, 21 Jan 2015 14:49:00 -0500 [thread overview]
Message-ID: <jwv4mrjzzx2.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87a91cxf5f.fsf@gmail.com> (Thierry Volpiatto's message of "Wed, 21 Jan 2015 17:38:36 +0100")
>> I'm not sure how to preserve the compatibility with this mistake.
I just pushed a change which includes a hack to preserve this old behavior.
> `:before' and `:after' specify execution order (i.e., when this
> form is called). If neither of these symbols are present, the
> default priority is used (before `:after' and after `:before');
> this default priority is represented in CLOS as `:primary'.
> I didn't specify :primary, because as I understand it is implicit if not
> mentionned, so IIUC I have to specify it now ?
Indeed you don't need to specify ":primary". The problem is that for
the type of the object used in the call, there is only one method that
can be used, and it's a :before method.
Before/after methods are like before/after advice: they are executed
before/after the "main course". In the case of methods, the "main
course" are the primary methods. Adding an after/before method when
there's no primary, is like adding an after/before advice to an
undefined function: if you're lucky the "before" advice/method will be
run first, but when this "before" advice/method finishes, you'll
get an error that the main course in undefined.
Stefan
next prev parent reply other threads:[~2015-01-21 19:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 7:18 bug#19645: 25.0.50; Recent EIEIO changes broke helm: Lisp error: (cl-no-next-method helm--setup-source Tassilo Horn
2015-01-21 16:03 ` Stefan Monnier
2015-01-21 16:38 ` Thierry Volpiatto
2015-01-21 17:36 ` Thierry Volpiatto
2015-01-21 19:51 ` Stefan Monnier
2015-01-21 19:49 ` Stefan Monnier [this message]
2015-01-21 20:58 ` Thierry Volpiatto
2015-01-21 21:53 ` Stefan Monnier
2015-01-22 4:17 ` Stefan Monnier
2015-01-22 7:00 ` Tassilo Horn
2015-01-22 17:08 ` Stefan Monnier
2015-01-23 7:08 ` Thierry Volpiatto
2015-01-23 20:56 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4mrjzzx2.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=19645@debbugs.gnu.org \
--cc=thierry.volpiatto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.