From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 9f31fb2: * lisp/progmodes/js.el (js-mode): Don't eagerly syntax propertize. Date: Sat, 22 Aug 2015 10:42:41 -0400 Message-ID: References: <20150821130356.5634.64124@vcs.savannah.gnu.org> <55D7E7E2.6010103@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1440254592 11272 80.91.229.3 (22 Aug 2015 14:43:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 22 Aug 2015 14:43:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 22 16:43:02 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZTA0Z-0005an-Kw for ged-emacs-devel@m.gmane.org; Sat, 22 Aug 2015 16:42:59 +0200 Original-Received: from localhost ([::1]:46784 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTA0Y-0006Fw-JJ for ged-emacs-devel@m.gmane.org; Sat, 22 Aug 2015 10:42:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTA0M-0006FN-3S for emacs-devel@gnu.org; Sat, 22 Aug 2015 10:42:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTA0I-00085D-Un for emacs-devel@gnu.org; Sat, 22 Aug 2015 10:42:46 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:61460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTA0I-00084N-QI for emacs-devel@gnu.org; Sat, 22 Aug 2015 10:42:42 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CtCwA731xV/5P+d0tcgxCEAsEMCYdLBAICgTw5FAEBAQEBAQGBCkEFg10BAQMBViMFCwsOJgcLFBgNJIg3CM8jAQEBBwIBH4s6hQUHhC0Fsz+BRSOCO4FZIoJ4AQEB X-IPAS-Result: A0CtCwA731xV/5P+d0tcgxCEAsEMCYdLBAICgTw5FAEBAQEBAQGBCkEFg10BAQMBViMFCwsOJgcLFBgNJIg3CM8jAQEBBwIBH4s6hQUHhC0Fsz+BRSOCO4FZIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="161037885" Original-Received: from 75-119-254-147.dsl.teksavvy.com (HELO pastel.home) ([75.119.254.147]) by ironport2-out.teksavvy.com with ESMTP; 22 Aug 2015 10:42:41 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id BDCBA622C3; Sat, 22 Aug 2015 10:42:41 -0400 (EDT) In-Reply-To: <55D7E7E2.6010103@dancol.org> (Daniel Colascione's message of "Fri, 21 Aug 2015 20:09:22 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:189064 Archived-At: > That call is needed for correctness, as I recall. Not really. It's needed to work around some problems elsewhere (most of those problems are not specific to js-mode, BTW). > Are you replacing it with something? We already replaced it with proper calls at a few other places. I'm sure there are still places where these calls are needed, but we should fix them rather than paper over them with this eager call. Stefan