Re: [Emacs-diffs] master 9f31fb2: * lisp/progmodes/js.el (js-mode): Don't eagerly syntax propertize.

Re: [Emacs-diffs] master 9f31fb2: * lisp/progmodes/js.el (js-mode): Don't eagerly syntax propertize.

[Daniel Colascione]

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

On 08/21/2015 06:03 AM, Stefan Monnier wrote:
> branch: master
> commit 9f31fb2a660a26ba510568fae102afc68db8f385
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     * lisp/progmodes/js.el (js-mode): Don't eagerly syntax propertize.
> ---
>  lisp/progmodes/js.el |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el
> index 40a4a10..98a22dd 100644
> --- a/lisp/progmodes/js.el
> +++ b/lisp/progmodes/js.el
> @@ -3560,9 +3560,10 @@ If one hasn't been set, or if it's stale,
prompt for a new one."
>    ;; the buffer containing the problem, JIT-lock will apply the
>    ;; correct syntax to the regular expression literal and the problem
>    ;; will mysteriously disappear.
> -  ;; FIXME: We should actually do this fontification lazily by adding
> +  ;; FIXME: We should instead do this fontification lazily by adding
>    ;; calls to syntax-propertize wherever it's really needed.
> -  (syntax-propertize (point-max)))
> +  ;;(syntax-propertize (point-max))
> +  )
>

That call is needed for correctness, as I recall. Are you replacing it
with something?



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [Emacs-diffs] master 9f31fb2: * lisp/progmodes/js.el (js-mode): Don't eagerly syntax propertize.

[Dmitry Gutov]

On 08/22/2015 06:09 AM, Daniel Colascione wrote:

> That call is needed for correctness, as I recall. Are you replacing it
> with something?

Ideally, syntax-propertize should be called only when needed. For 
instance, from font-lock or syntax-ppss calls.

Re: [Emacs-diffs] master 9f31fb2: * lisp/progmodes/js.el (js-mode): Don't eagerly syntax propertize.

[Stefan Monnier]

> That call is needed for correctness, as I recall.

Not really.  It's needed to work around some problems elsewhere (most
of those problems are not specific to js-mode, BTW).

> Are you replacing it with something?

We already replaced it with proper calls at a few other places.
I'm sure there are still places where these calls are needed, but we
should fix them rather than paper over them with this eager call.


        Stefan