all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Phillip Lord <phillip.lord@russet.org.uk>
Subject: Re: [Emacs-diffs] fix/undo-point-in-wrong-place 01beb39 2/2: Store value of point at beginning of last command.
Date: Mon, 23 Nov 2015 12:27:27 -0500	[thread overview]
Message-ID: <jwv4mgcy6h1.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1a0ukW-0007BU-Cd@vcs.savannah.gnu.org> (Phillip Lord's message of "Mon, 23 Nov 2015 17:17:56 +0000")

> +  if (last_point_position != beg &&
> +      current_buffer == prev_buffer )
> +    {
> +      record_point (last_point_position);
> +    }
 
If last_point_position really records the position of point at the
beginning of the command, then you'll get weird results if the comment
explicitly calls undo-boundary in the middle of its changes, since the
"second bundle" will end up with a spurious point movement.

I think you'd be better off just preserving the previous behavior
(i.e. make my suggested patch work and just fix the comments): less
work, and more guarantee that it won't introduce new regressions.


        Stefan



           reply	other threads:[~2015-11-23 17:27 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <E1a0ukW-0007BU-Cd@vcs.savannah.gnu.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv4mgcy6h1.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=phillip.lord@russet.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.