Bind non-essential in pcomplete to prevent tramp error

Bind non-essential in pcomplete to prevent tramp error

[Michael Albinus]

Hi,

Jürgen Hötzel has reported an error in pcomplete, see
<https://github.com/company-mode/company-mode/pull/487#issuecomment-195926034>.
The following patch in the emacs-25 branch fixes this:

--8<---------------cut here---------------start------------->8---
*** /usr/local/src/emacs-25/lisp/pcomplete.el.~d457fd9dc782465e1547f74021390c9d5951d6af~	2016-03-13 11:24:57.162148275 +0100
--- /usr/local/src/emacs-25/lisp/pcomplete.el	2016-03-13 11:12:53.540170107 +0100
***************
*** 501,507 ****
      (setq pcomplete-current-completions nil
  	  pcomplete-last-completion-raw nil)
      (catch 'pcompleted
!       (let* ((pcomplete-stub)
  	     pcomplete-seen pcomplete-norm-func
  	     pcomplete-args pcomplete-last pcomplete-index
  	     (pcomplete-autolist pcomplete-autolist)
--- 501,508 ----
      (setq pcomplete-current-completions nil
  	  pcomplete-last-completion-raw nil)
      (catch 'pcompleted
!       (let* ((non-essential t)
!              pcomplete-stub
  	     pcomplete-seen pcomplete-norm-func
  	     pcomplete-args pcomplete-last pcomplete-index
  	     (pcomplete-autolist pcomplete-autolist)
--8<---------------cut here---------------end--------------->8---

Is it OK to install the patch in the emacs-25 branch?

Best regards, Michael.

Re: Bind non-essential in pcomplete to prevent tramp error

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Date: Sun, 13 Mar 2016 11:29:43 +0100
> Cc: Jürgen Hötzel <juergen@archlinux.org>
> 
> --8<---------------cut here---------------start------------->8---
> *** /usr/local/src/emacs-25/lisp/pcomplete.el.~d457fd9dc782465e1547f74021390c9d5951d6af~	2016-03-13 11:24:57.162148275 +0100
> --- /usr/local/src/emacs-25/lisp/pcomplete.el	2016-03-13 11:12:53.540170107 +0100
> ***************
> *** 501,507 ****
>       (setq pcomplete-current-completions nil
>   	  pcomplete-last-completion-raw nil)
>       (catch 'pcompleted
> !       (let* ((pcomplete-stub)
>   	     pcomplete-seen pcomplete-norm-func
>   	     pcomplete-args pcomplete-last pcomplete-index
>   	     (pcomplete-autolist pcomplete-autolist)
> --- 501,508 ----
>       (setq pcomplete-current-completions nil
>   	  pcomplete-last-completion-raw nil)
>       (catch 'pcompleted
> !       (let* ((non-essential t)
> !              pcomplete-stub
>   	     pcomplete-seen pcomplete-norm-func
>   	     pcomplete-args pcomplete-last pcomplete-index
>   	     (pcomplete-autolist pcomplete-autolist)
> --8<---------------cut here---------------end--------------->8---
> 
> Is it OK to install the patch in the emacs-25 branch?

Looks reasonable to me, but I'd like to hear from Stefan as well.

Re: Bind non-essential in pcomplete to prevent tramp error

[John Wiegley]

>>>>> Eli Zaretskii <eliz@gnu.org> writes:

>> !       (let* ((non-essential t)
>> !              pcomplete-stub

>> Is it OK to install the patch in the emacs-25 branch?

> Looks reasonable to me, but I'd like to hear from Stefan as well.

Looks reasonable to me as well. It makes sense, since Tramp might be triggered
during generation of a completion list.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: Bind non-essential in pcomplete to prevent tramp error

[Stefan Monnier]

> !       (let* ((non-essential t)
> !              pcomplete-stub
>   	     pcomplete-seen pcomplete-norm-func
>   	     pcomplete-args pcomplete-last pcomplete-index
>   	     (pcomplete-autolist pcomplete-autolist)
> --8<---------------cut here---------------end--------------->8---
>
> Is it OK to install the patch in the emacs-25 branch?

Looks wrong.  Why would you consider this to be non-essential?


        Stefan

Re: Bind non-essential in pcomplete to prevent tramp error

[John Wiegley]

>>>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Looks wrong.  Why would you consider this to be non-essential?

It's "transitively non-essential", in that it can lead to prompting from Tramp
(or any other completion backend that might prompt).

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: Bind non-essential in pcomplete to prevent tramp error

[Stefan Monnier]

>> Looks wrong.  Why would you consider this to be non-essential?
> It's "transitively non-essential", in that it can lead to prompting from Tramp
> (or any other completion backend that might prompt).

I don't understand how that's relevant.  Of course, if you want to see
the completions you may have to enter the password.

I get the impression that the non-essential binding should be further up
in the caller.


        Stefan

Re: Bind non-essential in pcomplete to prevent tramp error

[Dmitry Gutov]

On 03/14/2016 12:53 AM, Stefan Monnier wrote:

> I get the impression that the non-essential binding should be further up
> in the caller.

Please try this:

M-x eshell

type 'cd /'

M-x pcomplete

I'm getting the error 'tramp-file-name-handler: Host name must not match 
method "adb"'.

Where should the fix be?

Re: Bind non-essential in pcomplete to prevent tramp error

[Stefan Monnier]

>> I get the impression that the non-essential binding should be further up
>> in the caller.
> Please try this:
> M-x eshell
> type 'cd /'
> M-x pcomplete
> I'm getting the error 'tramp-file-name-handler: Host name must not match
> method "adb"'.

Hmm... I get a *Completion* buffer with the expected contents (that was
using emacs-25).  Could we move this to a bug-report and get a backtrace?

> Where should the fix be?

Can't tell you based on this limited info, sorry,


        Stefan

Re: Bind non-essential in pcomplete to prevent tramp error

[Dmitry Gutov]

On 03/14/2016 02:18 AM, Stefan Monnier wrote:

> Hmm... I get a *Completion* buffer with the expected contents (that was
> using emacs-25).  Could we move this to a bug-report and get a backtrace?

http://debbugs.gnu.org/23006

No backtrace (it seems to signal user-error).

Re: Bind non-essential in pcomplete to prevent tramp error

[Michael Albinus]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> !       (let* ((non-essential t)
>> !              pcomplete-stub
>>   	     pcomplete-seen pcomplete-norm-func
>>   	     pcomplete-args pcomplete-last pcomplete-index
>>   	     (pcomplete-autolist pcomplete-autolist)
>> --8<---------------cut here---------------end--------------->8---
>>
>> Is it OK to install the patch in the emacs-25 branch?
>
> Looks wrong.  Why would you consider this to be non-essential?

Have you read the scenario presented by Jürgen? How would you solve this
differently?

`non-essential' was invented for cases like this: "It can be used to
prevent Tramp from ... displaying possible completions before the user
even asked for it."

>         Stefan

Best regards, Michael.

Re: Bind non-essential in pcomplete to prevent tramp error

[Stefan Monnier]

> Have you read the scenario presented by Jürgen?

No, where is that?  Do we have a bug# for it?

> `non-essential' was invented for cases like this: "It can be used to
> prevent Tramp from ... displaying possible completions before the user
> even asked for it."

That's right.  But that depends on the *caller* of pcomplete, because
it's not true of pcomplete in general.


        Stefan