From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#19200: Point adjustemnt moves *into* invisible text Date: Mon, 21 Mar 2016 16:43:21 -0400 Message-ID: References: <87mvpskb84.fsf@web.de> <87io0gbmpl.fsf@web.de> <87d1qnevco.fsf@web.de> <83h9fz65ze.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1458593064 10440 80.91.229.3 (21 Mar 2016 20:44:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Mar 2016 20:44:24 +0000 (UTC) Cc: michael_heerdegen@web.de, jonas@bernoul.li, 19200@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 21 21:44:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ai6gN-0004PL-S5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 21:44:11 +0100 Original-Received: from localhost ([::1]:60209 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai6gN-0000Ge-8j for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 16:44:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai6gJ-0000GY-CE for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 16:44:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai6gE-0000h5-Hw for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 16:44:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai6gE-0000h1-E5 for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 16:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ai6gE-0001y7-BI for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 16:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2016 20:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19200 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19200-submit@debbugs.gnu.org id=B19200.14585930127520 (code B ref 19200); Mon, 21 Mar 2016 20:44:02 +0000 Original-Received: (at 19200) by debbugs.gnu.org; 21 Mar 2016 20:43:32 +0000 Original-Received: from localhost ([127.0.0.1]:57380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai6fj-0001xE-NG for submit@debbugs.gnu.org; Mon, 21 Mar 2016 16:43:31 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:33661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai6fh-0001x4-Qf for 19200@debbugs.gnu.org; Mon, 21 Mar 2016 16:43:30 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u2LKhO1u032749; Mon, 21 Mar 2016 16:43:24 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 92F2E60587; Mon, 21 Mar 2016 16:43:21 -0400 (EDT) In-Reply-To: <83h9fz65ze.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 21 Mar 2016 20:28:05 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5617=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5617> : inlines <4542> : streams <1606668> : uri <2171602> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115273 Archived-At: > Can someone tell me why you think point adjustment has anything to do > with the original report for this bug? Because I fail to see any > connection; maybe I'm missing something. > What I see is that vertical-motion, called by next-line's subroutines, > ends up at position 5, because when it tries to get to column zero, it > skips the invisible text between positions 3 and 5. It stops at 5 > because the function called to move to the goal column can only move > within a single display line. IOW, this is a simple artifact of the > implementation of vertical-motion. No, it's OK for vertical-motion to move to position 5. But adjust_point_for_property should move it back to position 3 (because that still ends up being a forward motion, when compared to the original point position, and it is in a "less-invisible" spot). > Michael, does the patch below fix the Magit problem? (It does fix the > simple test case presented by Stefan at the beginning of this bug > report.) It just works around the problem, AFAICT. Stefan