From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: michael_heerdegen@web.de, jonas@bernoul.li, 19200@debbugs.gnu.org
Subject: bug#19200: Point adjustemnt moves *into* invisible text
Date: Mon, 21 Mar 2016 16:43:21 -0400 [thread overview]
Message-ID: <jwv4mbzwrzk.fsf-monnier+bug#19200@gnu.org> (raw)
In-Reply-To: <83h9fz65ze.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 21 Mar 2016 20:28:05 +0200")
> Can someone tell me why you think point adjustment has anything to do
> with the original report for this bug? Because I fail to see any
> connection; maybe I'm missing something.
> What I see is that vertical-motion, called by next-line's subroutines,
> ends up at position 5, because when it tries to get to column zero, it
> skips the invisible text between positions 3 and 5. It stops at 5
> because the function called to move to the goal column can only move
> within a single display line. IOW, this is a simple artifact of the
> implementation of vertical-motion.
No, it's OK for vertical-motion to move to position 5.
But adjust_point_for_property should move it back to position
3 (because that still ends up being a forward motion, when compared to
the original point position, and it is in a "less-invisible" spot).
> Michael, does the patch below fix the Magit problem? (It does fix the
> simple test case presented by Stefan at the beginning of this bug
> report.)
It just works around the problem, AFAICT.
Stefan
next prev parent reply other threads:[~2016-03-21 20:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 22:22 bug#19200: Point adjustemnt moves *into* invisible text Stefan Monnier
2016-03-20 22:58 ` Michael Heerdegen
2016-03-21 1:21 ` Stefan Monnier
2016-03-21 2:15 ` Michael Heerdegen
2016-03-21 2:23 ` Michael Heerdegen
2016-03-21 18:30 ` Eli Zaretskii
2016-03-21 12:08 ` Stefan Monnier
2016-03-21 14:52 ` Michael Heerdegen
2016-03-21 15:36 ` Stefan Monnier
2016-03-21 15:54 ` Michael Heerdegen
2016-03-21 18:08 ` Stefan Monnier
2016-03-21 18:28 ` Eli Zaretskii
2016-03-21 19:24 ` Michael Heerdegen
2016-03-21 19:40 ` Eli Zaretskii
2016-03-21 20:10 ` Michael Heerdegen
2016-03-21 20:21 ` Michael Heerdegen
2016-03-21 20:43 ` Stefan Monnier [this message]
2016-03-22 16:39 ` Eli Zaretskii
2016-03-22 18:36 ` Stefan Monnier
2016-03-22 18:52 ` Eli Zaretskii
2016-03-23 2:13 ` Stefan Monnier
2016-03-23 15:15 ` Eli Zaretskii
2016-03-23 15:32 ` Stefan Monnier
2016-03-23 15:42 ` Eli Zaretskii
2016-03-23 16:10 ` Stefan Monnier
2016-03-31 17:17 ` Eli Zaretskii
2016-03-31 18:04 ` Stefan Monnier
2016-03-31 23:32 ` Michael Heerdegen
2016-03-26 21:49 ` bug#19200: Point adjustment " John Wiegley
2016-03-21 18:31 ` bug#19200: Point adjustemnt " Eli Zaretskii
2016-03-21 18:50 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jwv4mbzwrzk.fsf-monnier+bug#19200@gnu.org' \
--to=monnier@iro.umontreal.ca \
--cc=19200@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jonas@bernoul.li \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.