Re: [Emacs-diffs] master 88fefc3 7/7: ; Merge: Lisp watchpoints (Bug#24923)

Re: [Emacs-diffs] master 88fefc3 7/7: ; Merge: Lisp watchpoints (Bug#24923)

[Stefan Monnier]

> +  else if (sym->redirect == SYMBOL_LOCALIZED
> +           && SYMBOL_BLV (sym)->frame_local)
> +    xsignal1 (Qtrapping_frame_local, symbol);

BTW, make-variable-frame-local has been declared obsolete since
Emacs-22.2, so I think now is a good time to get rid of
frame-local variables.


        Stefan

Killing frame-locals (was: [Emacs-diffs] master 88fefc3 7/7: ; Merge: Lisp watchpoints (Bug#24923))

[Stefan Monnier]

Ping?

I'll take care of the patch, if we agree,


        Stefan


>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> +  else if (sym->redirect == SYMBOL_LOCALIZED
>> +           && SYMBOL_BLV (sym)->frame_local)
>> +    xsignal1 (Qtrapping_frame_local, symbol);

> BTW, make-variable-frame-local has been declared obsolete since
> Emacs-22.2, so I think now is a good time to get rid of
> frame-local variables.


>         Stefan

Re: Killing frame-locals (was: [Emacs-diffs] master 88fefc3 7/7: ; Merge: Lisp watchpoints (Bug#24923))

[Noam Postavsky]

On Sat, Dec 17, 2016 at 9:31 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
> Ping?
>
> I'll take care of the patch, if we agree,
>
>
>         Stefan
>
>
>>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> +  else if (sym->redirect == SYMBOL_LOCALIZED
>>> +           && SYMBOL_BLV (sym)->frame_local)
>>> +    xsignal1 (Qtrapping_frame_local, symbol);
>
>> BTW, make-variable-frame-local has been declared obsolete since
>> Emacs-22.2, so I think now is a good time to get rid of
>> frame-local variables.
>

I did a web search for make-variable-frame-local, I found only
perspective-el still using it. I think it's a fairly popular package;
on the other hand, it's not in GNU ELPA, and it's not like they didn't
have warning in advance...

https://github.com/nex3/perspective-el/blob/1.12/perspective.el#L194-L197

;; make-variable-frame-local is obsolete according to the docs,
;; but I don't want to have to manually munge frame-parameters
;; all the time so I'm using it anyway.
(make-variable-frame-local

Re: Killing frame-locals

[Stefan Monnier]

OK, looks like there's no objection, so I'll install the patch.
Thanks,


        Stefan


>>>>> "Noam" == Noam Postavsky <npostavs@users.sourceforge.net> writes:

> On Sat, Dec 17, 2016 at 9:31 AM, Stefan Monnier
> <monnier@iro.umontreal.ca> wrote:
>> Ping?
>> 
>> I'll take care of the patch, if we agree,
>> 
>> 
>> Stefan
>> 
>> 
>>>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> 
>>>> +  else if (sym->redirect == SYMBOL_LOCALIZED
>>>> +           && SYMBOL_BLV (sym)->frame_local)
>>>> +    xsignal1 (Qtrapping_frame_local, symbol);
>> 
>>> BTW, make-variable-frame-local has been declared obsolete since
>>> Emacs-22.2, so I think now is a good time to get rid of
>>> frame-local variables.
>> 

> I did a web search for make-variable-frame-local, I found only
> perspective-el still using it. I think it's a fairly popular package;
> on the other hand, it's not in GNU ELPA, and it's not like they didn't
> have warning in advance...

> https://github.com/nex3/perspective-el/blob/1.12/perspective.el#L194-L197

> ;; make-variable-frame-local is obsolete according to the docs,
> ;; but I don't want to have to manually munge frame-parameters
> ;; all the time so I'm using it anyway.
> (make-variable-frame-local