From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 580a1b6: Respect .elpaignore when compiling and optimize compilation. Date: Mon, 26 Dec 2016 22:29:15 -0500 Message-ID: References: <20161223195027.29384.58430@vcs.savannah.gnu.org> <20161223195027.7C9E52201BC@vcs.savannah.gnu.org> <064dad34-c8c4-9135-2cbd-0ccd452de2cc@jacksonrayhamilton.com> <318da984-8e21-fece-3d61-2e3846a1cef6@jacksonrayhamilton.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1482809404 8394 195.159.176.226 (27 Dec 2016 03:30:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 27 Dec 2016 03:30:04 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Jackson Ray Hamilton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 27 04:29:59 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cLiSb-0001Mf-VH for ged-emacs-devel@m.gmane.org; Tue, 27 Dec 2016 04:29:58 +0100 Original-Received: from localhost ([::1]:52583 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cLiSg-0001vF-HN for ged-emacs-devel@m.gmane.org; Mon, 26 Dec 2016 22:30:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cLiS2-0001v9-Oy for emacs-devel@gnu.org; Mon, 26 Dec 2016 22:29:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cLiRx-0000fU-Rc for emacs-devel@gnu.org; Mon, 26 Dec 2016 22:29:22 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:47052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cLiRx-0000dM-NP for emacs-devel@gnu.org; Mon, 26 Dec 2016 22:29:17 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id uBR3TFjL025075; Mon, 26 Dec 2016 22:29:16 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id A9B02AE2A3; Mon, 26 Dec 2016 22:29:15 -0500 (EST) In-Reply-To: <318da984-8e21-fece-3d61-2e3846a1cef6@jacksonrayhamilton.com> (Jackson Ray Hamilton's message of "Mon, 26 Dec 2016 11:57:22 -0800") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV5900=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5900> : inlines <5608> : streams <1726413> : uri <2347661> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210830 Archived-At: >> I haven't looked at the performance side of this. It just seemed simpler. > I say we keep it as-is, as my reading of the current commands is simpler > than the way I read this alternative. Compare the way I read it: "Make > a tar archive and list its contents." Versus: "Execute tar with verbose > output, which happens to only include the files packaged, also that > output needs to be redirected from stderr to stdout for make to process > it, also bury the archive contents in /dev/null so as not to interfere > with the redirected verbose output." Fair enough. > Also, I've attached a patch for the "pwd-based exclusions" issue I > mentioned in my last email. I checked the timing on it, and it only > reduces the speed of "make" with nothing to do by about 50ms. Does it > look good to you? Looks OK. BTW, I saw that we could do included_els := $(shell tar -cvhf /dev/null --exclude-ignore=.elpaignore \ --exclude-vcs packages 2>&1 | grep '\.el$$') except that --exclude-ignore is a fairly recent addition to GNU tar, so it doesn't even work in Debian stable. Stefan