all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Jackson Ray Hamilton <jackson@jacksonrayhamilton.com>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] master 580a1b6: Respect .elpaignore when compiling and optimize compilation.
Date: Mon, 26 Dec 2016 22:29:15 -0500	[thread overview]
Message-ID: <jwv4m1q9hm2.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <318da984-8e21-fece-3d61-2e3846a1cef6@jacksonrayhamilton.com> (Jackson Ray Hamilton's message of "Mon, 26 Dec 2016 11:57:22 -0800")

>> I haven't looked at the performance side of this.  It just seemed simpler.
> I say we keep it as-is, as my reading of the current commands is simpler
> than the way I read this alternative.  Compare the way I read it: "Make
> a tar archive and list its contents."  Versus: "Execute tar with verbose
> output, which happens to only include the files packaged, also that
> output needs to be redirected from stderr to stdout for make to process
> it, also bury the archive contents in /dev/null so as not to interfere
> with the redirected verbose output."

Fair enough.

> Also, I've attached a patch for the "pwd-based exclusions" issue I
> mentioned in my last email.  I checked the timing on it, and it only
> reduces the speed of "make" with nothing to do by about 50ms.  Does it
> look good to you?

Looks OK.  BTW, I saw that we could do

    included_els := $(shell tar -cvhf /dev/null --exclude-ignore=.elpaignore \
                                --exclude-vcs packages 2>&1 | grep '\.el$$')

except that --exclude-ignore is a fairly recent addition to GNU tar, so
it doesn't even work in Debian stable.


        Stefan



      reply	other threads:[~2016-12-27  3:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161223195027.29384.58430@vcs.savannah.gnu.org>
     [not found] ` <20161223195027.7C9E52201BC@vcs.savannah.gnu.org>
2016-12-23 23:49   ` [elpa] master 580a1b6: Respect .elpaignore when compiling and optimize compilation Stefan Monnier
2016-12-24  6:58     ` Jackson Ray Hamilton
2016-12-26  4:16       ` Stefan Monnier
2016-12-26 19:57         ` Jackson Ray Hamilton
2016-12-27  3:29           ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv4m1q9hm2.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=jackson@jacksonrayhamilton.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.