From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Mark Oteiza <mvoteiza@udel.edu>
Subject: Re: [Emacs-diffs] master da3e101: ; Try not to affect match data
Date: Thu, 07 Sep 2017 20:16:33 -0400 [thread overview]
Message-ID: <jwv4lsejbfj.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20170906152102.0B61C20E37@vcs0.savannah.gnu.org> (Mark Oteiza's message of "Wed, 6 Sep 2017 11:21:01 -0400 (EDT)")
> ; Try not to affect match data
> * lisp/xdg.el (xdg-user-dir): Use save-match-data.
Why does it matter? Given the general way we handle match-data,
I think it's a bug for Elisp code to assume that something like
xdg-user-dir won't affect the match data.
Stefan
PS: And I just saw that the code says
"Return the path of user directory referred to by NAME."
which is wrong since the GNU convention is to use "path" only for
lists of directories (as in $PATH, $MANPATH, load-path, ...), so it
should say something like "file name" or just "Return the directory
referred to by NAME"
next parent reply other threads:[~2017-09-08 0:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170906152101.24092.40365@vcs0.savannah.gnu.org>
[not found] ` <20170906152102.0B61C20E37@vcs0.savannah.gnu.org>
2017-09-08 0:16 ` Stefan Monnier [this message]
2017-09-09 0:35 ` [Emacs-diffs] master da3e101: ; Try not to affect match data Mark Oteiza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4lsejbfj.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=mvoteiza@udel.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.