From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Abbrev suggestions - feedback appreciated Date: Sun, 17 Sep 2017 17:23:24 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505683422 9901 195.159.176.226 (17 Sep 2017 21:23:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 17 Sep 2017 21:23:42 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 17 23:23:38 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dth2Q-0002Kh-6B for ged-emacs-devel@m.gmane.org; Sun, 17 Sep 2017 23:23:38 +0200 Original-Received: from localhost ([::1]:33717 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dth2V-0004Ed-Uc for ged-emacs-devel@m.gmane.org; Sun, 17 Sep 2017 17:23:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dth2P-0004EQ-VF for emacs-devel@gnu.org; Sun, 17 Sep 2017 17:23:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dth2M-0003YA-QX for emacs-devel@gnu.org; Sun, 17 Sep 2017 17:23:37 -0400 Original-Received: from [195.159.176.226] (port=42663 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dth2M-0003Xi-JO for emacs-devel@gnu.org; Sun, 17 Sep 2017 17:23:34 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dth2A-0001ux-SK for emacs-devel@gnu.org; Sun, 17 Sep 2017 23:23:22 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 21 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:uLcgMWZqGqzW2FltA5IOymF5WcI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218432 Archived-At: >> You could avoid constructing the list by passing `word` to >> absug-get-active-abbrev-expansions and have it check equality as it >> goes. > That's a good optimization, thanks! At least as long as I am not trying > to tackle multi-word expansions. In that case, I don't know on > beforehand how many words to match. Again, surely possible to > solve... One way might be to save not one but, say, ten previous words, > and send that in to the function that will look for expansions matching > that. It would of course break on eleven words and above... > Any clever ideas? Actually, my "clever" idea was that you don't read any word at all: just go though the existing abbreviations, and check for each one of the if the text before point matches the expansion. Admittedly, I don't think we currently have a fast implementation of the equivalent of (looking-back (regexp-quote expansion)), so I don't know how well it will perform. Stefan