all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: "N. Raghavendra" <raghu@hri.res.in>
Cc: 28428@debbugs.gnu.org
Subject: bug#28428: comment-search-backward with no comments
Date: Fri, 22 Sep 2017 15:26:58 -0400	[thread overview]
Message-ID: <jwv4lruv8ku.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87poaieiah.fsf@hri.res.in> (N. Raghavendra's message of "Fri, 22 Sep 2017 23:18:22 +0530")

>> That looks fine, thank you.  But I think the simpler patch below works
>> as well:
>> -  (if (not (re-search-backward comment-start-skip limit t))
>> +  (if (not (re-search-backward comment-start-skip limit 'move))
> That's indeed nicer!  Thanks for pointing out that the NOERROR arg of
> `re-search-backward' can be given a value outside {t,nil} to move point
> to LIMIT.  It's a lesson to myself that I should read docstrings more
> carefully.

I think it's too risky for the emacs-26 branch, but feel free to install
it on master,


        Stefan





  reply	other threads:[~2017-09-22 19:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11 22:37 bug#28428: comment-search-backward with no comments N. Raghavendra
2017-09-22 16:40 ` Stefan Monnier
2017-09-22 17:48   ` N. Raghavendra
2017-09-22 19:26     ` Stefan Monnier [this message]
2017-09-22 20:31       ` N. Raghavendra
2017-09-23 21:07         ` Stefan Monnier
2017-09-24  0:26           ` N. Raghavendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv4lruv8ku.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=28428@debbugs.gnu.org \
    --cc=raghu@hri.res.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.