From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Two issues with the new Flymake Date: Fri, 03 Nov 2017 13:15:11 -0400 Message-ID: References: <87k1z7adxi.fsf@metapensiero.it> <87fu9va22c.fsf@metapensiero.it> <87mv43ti0j.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1509729341 30539 195.159.176.226 (3 Nov 2017 17:15:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Nov 2017 17:15:41 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 03 18:15:37 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAfZ4-0007ES-Kq for ged-emacs-devel@m.gmane.org; Fri, 03 Nov 2017 18:15:30 +0100 Original-Received: from localhost ([::1]:37748 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAfZB-0004ZH-Th for ged-emacs-devel@m.gmane.org; Fri, 03 Nov 2017 13:15:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAfZ4-0004Z8-IE for emacs-devel@gnu.org; Fri, 03 Nov 2017 13:15:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAfZ1-0000MM-E2 for emacs-devel@gnu.org; Fri, 03 Nov 2017 13:15:30 -0400 Original-Received: from [195.159.176.226] (port=37912 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eAfZ1-0000Ld-6y for emacs-devel@gnu.org; Fri, 03 Nov 2017 13:15:27 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eAfYp-0006Lm-3W for emacs-devel@gnu.org; Fri, 03 Nov 2017 18:15:15 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 16 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:wttkigNBTtmTsbWww8MiJxstPlo= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219893 Archived-At: > - (error (flymake-error "Invalid region line=%s col=%s" line col)))) > + (error (flymake-log :warning "Invalid region line=%s col=%s" line col)))) BTW, for the `master` branch, I think flymake should try to keep track of which pats of the buffer have changed since the process was launched, so that it can distinguish between spurious errors due to out-of-date information (as in this case), and real errors. At the very least it could keep enough info to know if *some* change took place or not (e.g. remember the value of buffer-text-modified-tick when the backend was launched). Again, this is not for the `emacs-26` branch. Stefan