From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master b5f4061: Drop forced lambda's from stream (Bug#30626) Date: Tue, 04 Jun 2019 09:27:09 -0400 Message-ID: References: <20190604002517.28469.52294@vcs0.savannah.gnu.org> <20190604002519.251AC209A5@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="135283"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: npostavs@gmail.com (Noam Postavsky) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 04 15:28:23 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hY9UC-000Yzc-Kr for ged-emacs-devel@m.gmane.org; Tue, 04 Jun 2019 15:28:20 +0200 Original-Received: from localhost ([127.0.0.1]:52680 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hY9UB-0004VE-Ix for ged-emacs-devel@m.gmane.org; Tue, 04 Jun 2019 09:28:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hY9T8-0004Bo-UC for emacs-devel@gnu.org; Tue, 04 Jun 2019 09:27:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hY9T7-0007Hx-P3 for emacs-devel@gnu.org; Tue, 04 Jun 2019 09:27:14 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53954) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hY9T7-0007FV-IF for emacs-devel@gnu.org; Tue, 04 Jun 2019 09:27:13 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 80A39101278; Tue, 4 Jun 2019 09:27:12 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 128DF1011A3; Tue, 4 Jun 2019 09:27:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1559654831; bh=2Ql7fn4K4G9u/8QWMtcRgZDm06aTfc94JXHu+KCTH/o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=k/vkcPGIR2UOaXG9riN+T65c1Y1pQRa7vFBpy/6h9+tfOUppDLJ3OGGjtwnXD/+zT fD+Oc6AuZFsgpVuIaKrWET6fvyNjslRGZylrH0bSz/fwljvntrDXd8+d4RwaefS6ik 4zyOru9g+ZjPkOJYCwuvGH0TWUYv76kUI3IVFRyGWDEzyfkxvggdKKoVNDNjOo7UAO ujwKWhmZAwCPTitTx3Bt5qAK/J60NwIQ70JYBaXm9gGH7YTsvHrRiCOtw0mAiKdZK3 McMTyjn7sKjwZQloy9S74H4+ipWOEKSSEtsTOQ3C4aYd6T3JzQL2lDkK9xGSJ/dZDM NdCt/UHbXsy9w== Original-Received: from pastel (unknown [45.72.167.35]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D621A120264; Tue, 4 Jun 2019 09:27:10 -0400 (EDT) In-Reply-To: <20190604002519.251AC209A5@vcs0.savannah.gnu.org> (Noam Postavsky's message of "Mon, 3 Jun 2019 20:25:18 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237247 Archived-At: > Let the stream id distinguish between forced and unforced stream > values. When the value is forced, replace the lambda with its result. > This lets the lambda and anything it references be garbage collected. Doesn't the same "memory leak" affect thunks? How 'bout the patch below Stefan diff --git a/lisp/emacs-lisp/thunk.el b/lisp/emacs-lisp/thunk.el index e1370c4591..8d28570dc2 100644 --- a/lisp/emacs-lisp/thunk.el +++ b/lisp/emacs-lisp/thunk.el @@ -54,16 +54,15 @@ thunk-delay "Delay the evaluation of BODY." (declare (debug t)) (cl-assert lexical-binding) - (let ((forced (make-symbol "forced")) - (val (make-symbol "val"))) - `(let (,forced ,val) - (lambda (&optional check) - (if check - ,forced - (unless ,forced - (setf ,val (progn ,@body)) - (setf ,forced t)) - ,val))))) + `(let (forced + (val (lambda () ,@body))) + (lambda (&optional check) + (if check + forced + (unless forced + (setf val (funcall val)) + (setf forced t)) + val)))) (defun thunk-force (delayed) "Force the evaluation of DELAYED.