* Re: [Emacs-diffs] master dde0320: * lisp/replace.el (replace-highlight): Add save-match-data (bug#36328)
[not found] ` <20190705191141.C019D20552@vcs0.savannah.gnu.org>
@ 2019-07-05 20:24 ` Stefan Monnier
2019-07-07 22:18 ` Juri Linkov
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2019-07-05 20:24 UTC (permalink / raw)
To: Juri Linkov; +Cc: emacs-devel
> - (isearch-lazy-highlight-new-loop range-beg range-end))))
> + (save-match-data
> + ;; Preserve match-data for perform-replace since
Then the save-match-data should be in perform-replace, not here,
I think.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Emacs-diffs] master dde0320: * lisp/replace.el (replace-highlight): Add save-match-data (bug#36328)
2019-07-05 20:24 ` [Emacs-diffs] master dde0320: * lisp/replace.el (replace-highlight): Add save-match-data (bug#36328) Stefan Monnier
@ 2019-07-07 22:18 ` Juri Linkov
0 siblings, 0 replies; 2+ messages in thread
From: Juri Linkov @ 2019-07-07 22:18 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
>> - (isearch-lazy-highlight-new-loop range-beg range-end))))
>> + (save-match-data
>> + ;; Preserve match-data for perform-replace since
>
> Then the save-match-data should be in perform-replace, not here,
> I think.
This means code duplication, but ok, this will make code cleaner.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-07 22:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190705191140.31351.77660@vcs0.savannah.gnu.org>
[not found] ` <20190705191141.C019D20552@vcs0.savannah.gnu.org>
2019-07-05 20:24 ` [Emacs-diffs] master dde0320: * lisp/replace.el (replace-highlight): Add save-match-data (bug#36328) Stefan Monnier
2019-07-07 22:18 ` Juri Linkov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.